From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nathan Trapuzzano <nbtrap@nbtrap.com>
Cc: Stephen Berman <stephen.berman@gmx.net>, 15778@debbugs.gnu.org
Subject: bug#15778: 24.3; cperl-mode causes emacs to lock up
Date: Sun, 03 Nov 2013 20:48:46 -0500 [thread overview]
Message-ID: <jwv4n7tndkd.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87li15p0am.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Sun, 03 Nov 2013 17:50:41 -0500")
> - (if (setq beg (cperl-beginning-of-property beg 'syntax-type))
> - (goto-char beg)))
> + (let ((new-beg (cperl-beginning-of-property beg 'syntax-type)))
> + (setq beg (if (= new-beg beg) nil new-beg))
> + (goto-char new-beg)))
Hmm... what if new-beg is nil?
The current code explicitly tests this case to avoid calling
`goto-char', whereas your code calls goto-char unconditionally.
Why?
Stefan
next prev parent reply other threads:[~2013-11-04 1:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 11:19 bug#15778: 24.3; cperl-mode causes emacs to lock up Nathan Trapuzzano
2013-11-01 11:46 ` Eli Zaretskii
2013-11-01 12:16 ` Nathan Trapuzzano
2013-11-01 14:41 ` Eli Zaretskii
2013-11-01 14:59 ` Nathan Trapuzzano
2013-11-01 16:26 ` Eli Zaretskii
2013-11-01 17:21 ` Nathan Trapuzzano
2013-11-01 20:23 ` Stephen Berman
2013-11-03 0:00 ` Stephen Berman
2013-11-03 12:00 ` Nathan Trapuzzano
2013-11-03 13:41 ` Stephen Berman
2013-11-03 13:59 ` Nathan Trapuzzano
2013-11-03 19:39 ` Stephen Berman
2013-11-03 19:48 ` Nathan Trapuzzano
2013-11-03 22:22 ` Stephen Berman
2013-11-03 22:50 ` Nathan Trapuzzano
2013-11-04 1:48 ` Stefan Monnier [this message]
2013-11-04 2:29 ` Nathan Trapuzzano
2013-11-04 3:52 ` Stefan Monnier
2013-11-03 14:15 ` Stefan Monnier
2013-11-03 14:23 ` Nathan Trapuzzano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4n7tndkd.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=15778@debbugs.gnu.org \
--cc=nbtrap@nbtrap.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).