From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.bugs Subject: bug#16993: advice-add hides docstring Date: Thu, 20 Mar 2014 08:56:16 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1395320235 18213 80.91.229.3 (20 Mar 2014 12:57:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Mar 2014 12:57:15 +0000 (UTC) Cc: 16993@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 20 13:57:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WQcXD-0004EQ-J4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Mar 2014 13:57:23 +0100 Original-Received: from localhost ([::1]:46844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQcXD-0005z9-8s for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Mar 2014 08:57:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQcX2-0005gH-1M for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 08:57:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQcWu-0007UA-9b for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 08:57:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQcWu-0007U0-6D for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 08:57:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WQcWt-0003uk-Bs for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2014 08:57:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Mar 2014 12:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16993-submit@debbugs.gnu.org id=B16993.139532018414991 (code B ref 16993); Thu, 20 Mar 2014 12:57:02 +0000 Original-Received: (at 16993) by debbugs.gnu.org; 20 Mar 2014 12:56:24 +0000 Original-Received: from localhost ([127.0.0.1]:41938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQcWF-0003ti-SV for submit@debbugs.gnu.org; Thu, 20 Mar 2014 08:56:24 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19575) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WQcW9-0003tV-Gc for 16993@debbugs.gnu.org; Thu, 20 Mar 2014 08:56:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDjhiWYoFegxM X-IPAS-Result: Av4EABK/CFHO+KKg/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDjhiWYoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="52745276" Original-Received: from 206-248-162-160.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.160]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Mar 2014 08:56:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 652E86012B; Thu, 20 Mar 2014 08:56:16 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Thu, 20 Mar 2014 06:18:01 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87012 Archived-At: >> We can either fix it by teaching Snarf-documentation about advised >> function (yuck!) or by not advising functions that are documented in >> DOC. IOW the right fix is to get rid of those advices in uniquify.el. > IIUC, you're not proposing to delay the advice-add calls, but remove > them altogether. Right. > How would you re-implement the current functionality so rename-buffer > and create-file-buffer still respect uniquify? Some kind of hook in > these functions? I haven't looked at it yet, but last time I looked at removing uniquify's advices (that was many years ago), I couldn't come up with a good hook, so I expect that we'll "simply" change the current code of those 2 functions by adding explicit calls to uniquify. Stefan