From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source... Date: Wed, 21 Jan 2015 14:49:00 -0500 Message-ID: References: <87sif4txdv.fsf@gnu.org> <87a91cxf5f.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421869824 30254 80.91.229.3 (21 Jan 2015 19:50:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Jan 2015 19:50:24 +0000 (UTC) Cc: 19645@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 21 20:50:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YE1I5-0007Sf-S7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jan 2015 20:50:14 +0100 Original-Received: from localhost ([::1]:49950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE1I5-0001P5-6m for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jan 2015 14:50:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE1I1-0001OO-II for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 14:50:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YE1Hw-0003Hw-EZ for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 14:50:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE1Hw-0003H5-Bt for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 14:50:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YE1Hv-0001ch-Ku for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 14:50:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jan 2015 19:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19645 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19645-submit@debbugs.gnu.org id=B19645.14218697716191 (code B ref 19645); Wed, 21 Jan 2015 19:50:03 +0000 Original-Received: (at 19645) by debbugs.gnu.org; 21 Jan 2015 19:49:31 +0000 Original-Received: from localhost ([127.0.0.1]:52117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YE1HO-0001bn-9W for submit@debbugs.gnu.org; Wed, 21 Jan 2015 14:49:30 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:42780) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YE1HL-0001be-GJ for 19645@debbugs.gnu.org; Wed, 21 Jan 2015 14:49:28 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id F261585E88; Wed, 21 Jan 2015 14:49:26 -0500 (EST) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id BF4C91E5B9B; Wed, 21 Jan 2015 14:49:00 -0500 (EST) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id A4311B4102; Wed, 21 Jan 2015 14:49:00 -0500 (EST) In-Reply-To: <87a91cxf5f.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 21 Jan 2015 17:38:36 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98557 Archived-At: >> I'm not sure how to preserve the compatibility with this mistake. I just pushed a change which includes a hack to preserve this old behavior. > `:before' and `:after' specify execution order (i.e., when this > form is called). If neither of these symbols are present, the > default priority is used (before `:after' and after `:before'); > this default priority is represented in CLOS as `:primary'. > I didn't specify :primary, because as I understand it is implicit if not > mentionned, so IIUC I have to specify it now ? Indeed you don't need to specify ":primary". The problem is that for the type of the object used in the call, there is only one method that can be used, and it's a :before method. Before/after methods are like before/after advice: they are executed before/after the "main course". In the case of methods, the "main course" are the primary methods. Adding an after/before method when there's no primary, is like adding an after/before advice to an undefined function: if you're lucky the "before" advice/method will be run first, but when this "before" advice/method finishes, you'll get an error that the main course in undefined. Stefan