From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20468: Erc timestamps and buffer-invisibility-spec Date: Wed, 24 Jun 2015 10:17:23 -0400 Message-ID: References: <558a5d6c.8651c20a.75f24.1efc@mx.google.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1435155510 12419 80.91.229.3 (24 Jun 2015 14:18:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Jun 2015 14:18:30 +0000 (UTC) Cc: 20468@debbugs.gnu.org To: =?UTF-8?Q?C=C3=A9dric_?= =?UTF-8?Q?Ch=C3=A9pied?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 24 16:18:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z7lVF-0001zm-0P for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jun 2015 16:18:13 +0200 Original-Received: from localhost ([::1]:50922 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7lVD-0002EK-Sr for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jun 2015 10:18:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7lVA-0002Db-Fz for bug-gnu-emacs@gnu.org; Wed, 24 Jun 2015 10:18:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7lV5-0000dM-C1 for bug-gnu-emacs@gnu.org; Wed, 24 Jun 2015 10:18:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7lV5-0000dI-8k for bug-gnu-emacs@gnu.org; Wed, 24 Jun 2015 10:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z7lV5-0000zv-2V for bug-gnu-emacs@gnu.org; Wed, 24 Jun 2015 10:18:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jun 2015 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20468 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20468-submit@debbugs.gnu.org id=B20468.14351554523791 (code B ref 20468); Wed, 24 Jun 2015 14:18:02 +0000 Original-Received: (at 20468) by debbugs.gnu.org; 24 Jun 2015 14:17:32 +0000 Original-Received: from localhost ([127.0.0.1]:56550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7lUa-0000z3-5R for submit@debbugs.gnu.org; Wed, 24 Jun 2015 10:17:32 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:22319) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7lUX-0000yn-FG for 20468@debbugs.gnu.org; Wed, 24 Jun 2015 10:17:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A6FgA731xV/3+MCkxcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kiDcIzyMBAQEBAQUCAR+LOoUFB4QtBbM/gUUjhBQigngBAQE X-IPAS-Result: A0A6FgA731xV/3+MCkxcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA0kiDcIzyMBAQEBAQUCAR+LOoUFB4QtBbM/gUUjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="128170379" Original-Received: from 76-10-140-127.dsl.teksavvy.com (HELO ceviche.home) ([76.10.140.127]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Jun 2015 10:17:23 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id A155E660F3; Wed, 24 Jun 2015 10:17:23 -0400 (EDT) In-Reply-To: <558a5d6c.8651c20a.75f24.1efc@mx.google.com> ("=?UTF-8?Q?C=C3=A9dric_?= =?UTF-8?Q?Ch=C3=A9pied?="'s message of "Wed, 24 Jun 2015 09:34:03 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104299 Archived-At: > Is it a bug? Should the default value be (t) instead of t? Right, now I finally see where the problem was introduced: the ERC code always starts by calling erc-munge-invisibility-spec, so by default, the old code ended up setting buffer-invisibility-spec to `(t)', whereas the new code calls remove-from-invisibility-spec which ends up not doing anything. I'm tempted to install the patch below, since I think it makes sense to expect that remove-from-invisibility-spec makes ELEMENT visible. Stefan diff --git a/lisp/subr.el b/lisp/subr.el index 9580109..e9a5a2a 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -4172,9 +4173,10 @@ that can be added." (defun remove-from-invisibility-spec (element) "Remove ELEMENT from `buffer-invisibility-spec'." - (if (consp buffer-invisibility-spec) - (setq buffer-invisibility-spec - (delete element buffer-invisibility-spec)))) + (setq buffer-invisibility-spec + (if (consp buffer-invisibility-spec) + (delete element buffer-invisibility-spec) + (list t)))) ;;;; Syntax tables.