* bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings
@ 2013-06-01 22:39 Glenn Morris
2013-06-02 2:42 ` Stefan Monnier
2015-11-25 11:12 ` Alan Mackenzie
0 siblings, 2 replies; 7+ messages in thread
From: Glenn Morris @ 2013-06-01 22:39 UTC (permalink / raw)
To: 14529
Package: emacs
Severity: minor
Version: 24.3.50
There are these (spurious?) warnings while bootstrapping:
the function `gv--defsetter' might not be defined at runtime.
(image-mode, winner, avl-tree, eieio)
the function `advice--set-buffer-local' might not be defined at runtime.
(mailabbrev)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings
2013-06-01 22:39 bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings Glenn Morris
@ 2013-06-02 2:42 ` Stefan Monnier
2018-03-23 21:16 ` Glenn Morris
2015-11-25 11:12 ` Alan Mackenzie
1 sibling, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2013-06-02 2:42 UTC (permalink / raw)
To: Glenn Morris; +Cc: 14529
> the function `gv--defsetter' might not be defined at runtime.
> (image-mode, winner, avl-tree, eieio)
gv--setter is used inside a function placed on the `gv-expander'
property of some symbols, which should never be used except by gv.el
code (at which point gv--defsetter will be defined).
> the function `advice--set-buffer-local' might not be defined at runtime.
> (mailabbrev)
Hmmm... not sure what that is.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings
2013-06-01 22:39 bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings Glenn Morris
2013-06-02 2:42 ` Stefan Monnier
@ 2015-11-25 11:12 ` Alan Mackenzie
1 sibling, 0 replies; 7+ messages in thread
From: Alan Mackenzie @ 2015-11-25 11:12 UTC (permalink / raw)
To: Glenn Morris; +Cc: 14529-done
This bug has gone away. Closing.
On Sat, Jun 01, 2013 at 06:39:46PM -0400, Glenn Morris wrote:
> Package: emacs
> Severity: minor
> Version: 24.3.50
> There are these (spurious?) warnings while bootstrapping:
> the function `gv--defsetter' might not be defined at runtime.
> (image-mode, winner, avl-tree, eieio)
> the function `advice--set-buffer-local' might not be defined at runtime.
> (mailabbrev)
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings
2013-06-02 2:42 ` Stefan Monnier
@ 2018-03-23 21:16 ` Glenn Morris
2018-03-23 23:25 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2018-03-23 21:16 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 14529
Stefan Monnier wrote:
>> the function `gv--defsetter' might not be defined at runtime.
>> (image-mode, winner, avl-tree []
>
> gv--setter is used inside a function placed on the `gv-expander'
> property of some symbols, which should never be used except by gv.el
> code (at which point gv--defsetter will be defined).
These warnings have come back following 97b7e58.
Obviously they can be declare-functioned away, but it would be nicer if
there was a general solution that did not require modifying each file
that declares a gv-setter.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings
2018-03-23 21:16 ` Glenn Morris
@ 2018-03-23 23:25 ` Stefan Monnier
2018-04-17 18:28 ` Glenn Morris
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2018-03-23 23:25 UTC (permalink / raw)
To: Glenn Morris; +Cc: 14529
Glenn Morris <rgm@gnu.org> writes:
> Stefan Monnier wrote:
>
>>> the function `gv--defsetter' might not be defined at runtime.
>>> (image-mode, winner, avl-tree []
>>
>> gv--setter is used inside a function placed on the `gv-expander'
>> property of some symbols, which should never be used except by gv.el
>> code (at which point gv--defsetter will be defined).
>
> These warnings have come back following 97b7e58.
> Obviously they can be declare-functioned away, but it would be nicer if
> there was a general solution that did not require modifying each file
> that declares a gv-setter.
I'd love to have a general way to say things like "code on symbol
property `gv-expand' can use any function provided by gv.el", but in the
mean time would the patch below work?
Stefan
diff --git a/lisp/emacs-lisp/gv.el b/lisp/emacs-lisp/gv.el
index 1e5347d206..230d59f189 100644
--- a/lisp/emacs-lisp/gv.el
+++ b/lisp/emacs-lisp/gv.el
@@ -216,6 +216,8 @@ gv-define-setter
(declare (indent 2) (debug (&define name sexp body)))
`(gv-define-expander ,name
(lambda (do &rest args)
+ (declare-function
+ gv--defsetter "gv" (name setter do args &optional vars))
(gv--defsetter ',name (lambda ,arglist ,@body) do args))))
;;;###autoload
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings
2018-03-23 23:25 ` Stefan Monnier
@ 2018-04-17 18:28 ` Glenn Morris
2018-04-18 19:57 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2018-04-17 18:28 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 14529
Stefan Monnier wrote:
> --- a/lisp/emacs-lisp/gv.el
> +++ b/lisp/emacs-lisp/gv.el
> @@ -216,6 +216,8 @@ gv-define-setter
> (declare (indent 2) (debug (&define name sexp body)))
> `(gv-define-expander ,name
> (lambda (do &rest args)
> + (declare-function
> + gv--defsetter "gv" (name setter do args &optional vars))
> (gv--defsetter ',name (lambda ,arglist ,@body) do args))))
>
> ;;;###autoload
Works for me, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings
2018-04-17 18:28 ` Glenn Morris
@ 2018-04-18 19:57 ` Stefan Monnier
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2018-04-18 19:57 UTC (permalink / raw)
To: Glenn Morris; +Cc: 14529
> Works for me, thanks.
Pushed to master. Can we close this bug or is the
advice--set-buffer-local still pending?
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-18 19:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-01 22:39 bug#14529: gv--defsetter, advice--set-buffer-local compilation warnings Glenn Morris
2013-06-02 2:42 ` Stefan Monnier
2018-03-23 21:16 ` Glenn Morris
2018-03-23 23:25 ` Stefan Monnier
2018-04-17 18:28 ` Glenn Morris
2018-04-18 19:57 ` Stefan Monnier
2015-11-25 11:12 ` Alan Mackenzie
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).