unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 24467@debbugs.gnu.org, SK Kim <tttuuu888@gmail.com>,
	npostavs@users.sourceforge.net
Subject: bug#24467: 25.1; package
Date: Sat, 03 Nov 2018 11:07:25 -0400	[thread overview]
Message-ID: <jwv4lcy5hqz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k2e0gkvd.fsf@web.de> (Michael Heerdegen's message of "Sun, 25 Sep 2016 15:38:30 +0200")

>> Ah, so the packages are "new" in the sense that they come from
>> archives added after package-initialize was called.
>
> I'm not sure whether this is by design and if we would break something
> if we changed it.  I think the fix would be quite trivial: simply
> speaking, we would change `package-read-all-archive-contents' to iterate
> over "$package-user-dir/archives/*" instead of `package-archives'.

It's clearly a bug, and it's made worse in Emacs-27 where
package-initialize is called automatically before reading ~/.emacs.

IOW, I think "this" needs to be fixed before Emacs-27.1.

The fix you propose might work (tho with unintended side effects), but
I don't see any reason why we need to package-read-all-archive-contents
so early on anyway.  More specifically, package-activate-all should be
changed so it doesn't end up running package-read-all-archive-contents:
it's already the case when a package-quickstart-file is found, but if
there's no such file we call package-initialize which ends up calling
package-read-all-archive-contents even though we're only interested in
the package-load-all-descriptors part, really.


        Stefan





  reply	other threads:[~2018-11-03 15:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19  5:29 bug#24467: 25.1; package SK Kim
2016-09-19 22:01 ` Noam Postavsky
2016-09-24 22:28   ` Michael Heerdegen
2016-09-25  2:45     ` npostavs
2016-09-25 13:38       ` Michael Heerdegen
2018-11-03 15:07         ` Stefan Monnier [this message]
2019-01-22 22:56           ` Stefan Monnier
2021-08-16 12:26             ` bug#21703: adding package archives after calling package-initialize lists all their packages as "new" Lars Ingebrigtsen
2021-08-17 12:39               ` bug#24467: " Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4lcy5hqz.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=24467@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=npostavs@users.sourceforge.net \
    --cc=tttuuu888@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).