From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9917: 24.0.90; Make `goto-line' consistent with the line number from the minibuffer Date: Sat, 19 Sep 2020 14:01:07 -0400 Message-ID: References: <877dspmzo3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1583"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dani Moncayo , 9917@debbugs.gnu.org, 5042@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 19 20:02:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJhBl-0000Io-TX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 20:02:21 +0200 Original-Received: from localhost ([::1]:50506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJhBk-0006h0-R9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Sep 2020 14:02:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJhBS-0006gQ-Rn for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:02:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJhBS-000579-It for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJhBS-0002jV-Gj for bug-gnu-emacs@gnu.org; Sat, 19 Sep 2020 14:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Sep 2020 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9917 X-GNU-PR-Package: emacs Original-Received: via spool by 9917-submit@debbugs.gnu.org id=B9917.160053847810433 (code B ref 9917); Sat, 19 Sep 2020 18:02:02 +0000 Original-Received: (at 9917) by debbugs.gnu.org; 19 Sep 2020 18:01:18 +0000 Original-Received: from localhost ([127.0.0.1]:48067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJhAk-0002i8-BK for submit@debbugs.gnu.org; Sat, 19 Sep 2020 14:01:18 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJhAi-0002hk-3h; Sat, 19 Sep 2020 14:01:16 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4AD7D10022D; Sat, 19 Sep 2020 14:01:10 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5AE3910022A; Sat, 19 Sep 2020 14:01:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600538468; bh=wA0NzSvXhfKxIfgxtneecyse9brm29cqiFa/dIzygsk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kP2rBiB+wTnX+Tk8+aWLlSQcAeeaxY+tY5ES6XNR47R8wwEG0yiD9nAWLKPMd4UFn f9KT4LXa5hQNO0naFwGXAUK7HILP4f+1saN/A55T5kXy/DUdvCc7D1A2YabFw1eIz7 8EJkd+HfdJNtOX1N/RSfA7plYeiRNKIk8ex1CihKr6HdWe63iviLJ5jnuA+GrEcgMt rpSkuuRgOmdY8mjaqlZ6TTXEckKI6K5vovGL67Oyl00bogFLikz8WLxqzt4AV7vrud 0Nzg14LxtBJhV/pCraMMf2Idfs81sXB9wQzgx9QM+bS8kfzuRBETAQV4HxjIf/nxCC edPF9uGio2WPA== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CC0551204F0; Sat, 19 Sep 2020 14:01:07 -0400 (EDT) In-Reply-To: <877dspmzo3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 19 Sep 2020 19:42:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188423 Archived-At: > The suggestion here is to make the interactive `goto-line' go to the > narrowed-to line instead of the absolute line. I can see the reasoning > here -- especially after `display-line-numbers-mode' was added, > displaying line numbers seems to be getting more popular, and having > `M-x goto-char' not going to the number you're seeing (if the buffer is > narrowed) sounds confusing. I agree that the same should be used for `M-g g` and for the numbers displayed in `display-line-numbers-mode' or in the mode-line. I think all those need some common way to decide if the first line is at `point-min` or somewhere else. > But it is a breaking change -- somewhat. `goto-line' isn't supposed to > be used in code, and isn't used in-tree, but who knows what people have > done out there... Agree. We used to have calls to `goto-line` in our code, so there's probably more in the wild. > We could bind `M-g g' (and friends) to a new command that acts this > new way? Fine by me, Stefan