unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: 47678@debbugs.gnu.org
Subject: bug#47678: 27.1; `completion-boundaries` assertion failure for file
Date: Tue, 13 Apr 2021 08:46:22 -0400	[thread overview]
Message-ID: <jwv4kga5pjm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <e87cf9ba-ba66-6c12-5b92-ec390dc4a5c2@daniel-mendler.de> (Daniel Mendler's message of "Tue, 13 Apr 2021 06:04:24 +0200")

> Thank you for looking into this. I hope this will not lead to further
> problems, it is mostly an edge case when moving around the cursor and the
> path at that point is not really valid? What kind of issues could happen?
> I can always enter some invalid/shadowed path ///, /~~~/, ~/~/~, which do
> not make problems (at least with this patch).

The problem has to do with quoting/unquoting: in `C-x C-f` we do not
quite enter "raw file name" because the name typed by the user is passed
through `substitute-in-file-name` which expands envvar references (and
de-doubles dollars for those files whose name looks like an envvar
reference) and does some truncation (like foo//bar => /bar).

So the `completion-file-name-table` (which completes raw file names) is
wrapped via `completion-table-with-quoting` and this function has to be
able to relate the unquoted text back to the quoted text, for example in
order to convert the boundaries returned by `completion-file-name-table`
(on the unquoted file name) into the corresponding boundaries that apply
to the quoted file name.

This is in general somewhere between hard and impossible.  So if/when we
get those boundaries wrong (for example) it may lead to misbehavior down
the line.
I'd rather not try and guess what those might be.
I'm just hoping that they're minor enough and rare enough.


        Stefan






  reply	other threads:[~2021-04-13 12:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 20:35 bug#47678: 27.1; `completion-boundaries` assertion failure for file Daniel Mendler
2021-04-12 23:28 ` Stefan Monnier
2021-04-13  4:04   ` Daniel Mendler
2021-04-13 12:46     ` Stefan Monnier [this message]
2021-04-13 14:44       ` Daniel Mendler
2021-04-13 22:34         ` Stefan Monnier
2021-05-06 10:01           ` Lars Ingebrigtsen
2021-05-06 11:07             ` Daniel Mendler
2021-05-07 11:14               ` Lars Ingebrigtsen
2021-05-08 23:41               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-09  8:34                 ` Daniel Mendler
2021-05-09 13:37                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv4kga5pjm.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=47678@debbugs.gnu.org \
    --cc=mail@daniel-mendler.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).