From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Mon, 03 May 2021 15:41:47 -0400 Message-ID: References: <834kfmabvs.fsf@gnu.org> <83tunj651i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22550"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: ioannis.kappas@gmail.com, 48137@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 03 21:42:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldeSX-0005lp-Sn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 21:42:26 +0200 Original-Received: from localhost ([::1]:45546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldeSW-0003En-Ty for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 May 2021 15:42:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldeSB-0003Db-Au for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 15:42:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldeSA-0003mV-7w for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 15:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ldeSA-0004SE-6B for bug-gnu-emacs@gnu.org; Mon, 03 May 2021 15:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 May 2021 19:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.162007091717115 (code B ref 48137); Mon, 03 May 2021 19:42:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 3 May 2021 19:41:57 +0000 Original-Received: from localhost ([127.0.0.1]:48326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldeS5-0004Rz-F7 for submit@debbugs.gnu.org; Mon, 03 May 2021 15:41:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ldeS3-0004Rt-NZ for 48137@debbugs.gnu.org; Mon, 03 May 2021 15:41:56 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6DC8F809E6; Mon, 3 May 2021 15:41:50 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E82EC80462; Mon, 3 May 2021 15:41:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620070908; bh=kWGt9qb+4ULFvGuNJrEr499Kuu1VTnFYdI1r0Vw+WMw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZkFbWHlRAkEe+xVCJYFB/czMhKvuZ7s6Znc8HuSAyIgue5P5NCS9R0fIIXlXSPKag bzQmQWQVZNxQXf4uc8sRojRjzAsGrtjj4OGCLXztbHFaBuU89XZVwurSAgR7Y598oQ eUNzFtov5re49Zl25x0Cnr2vYfDQa3gX0U6rOZ/eBaf0ks8j7VNF8BaxbFhl/ZJxhT UrV4b85Xil1OY1Jg+RpKuBoNFtlpEDIgTuGcm4YnGgLk1ncd8BJMoZsOJpk+nLKjYA s0NWH9WV7+gUSoepxTI0xR+lCGR1aMX+eem/DoR3JxaJ7td4TcUKAsFO6yr1suuJZ4 0IOQNXOXP8wpg== Original-Received: from alfajor (unknown [108.161.125.61]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B5AFB120192; Mon, 3 May 2021 15:41:48 -0400 (EDT) In-Reply-To: <83tunj651i.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 May 2021 21:33:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205558 Archived-At: > I think it's wrong for package.el to try to decode these files. It > should deliver the files to the disk exactly as they are received > through the wire. And the only safe way of doing that is to treat > these files as raw bytes. I'm not sure what you're referring to here. In the OP's case, i.e. `package-install-file` (which is a seldom used functionality, not part of the "normal" `package-install`) the file doesn't go through the wire: it's already "local" and we currently implement this code on top of `package-install-from-buffer`, so it has to work correctly with an already-decoded buffer. Stefan