From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47969: 28.0.50; Losing minibuffer focus in trying M-x command Date: Thu, 06 May 2021 10:18:53 -0400 Message-ID: References: <24706.50397.801563.461736@capuchin.co.uk> <242e45b6-6dee-c85a-2ac8-67b2adeb93b5@gmx.at> <838s4w6mua.fsf@gnu.org> <83y2cv6773.fsf@gnu.org> <1a73bd6c69efd6282e57@heytings.org> <83bl9q676g.fsf@gnu.org> <1a73bd6c69e27aed1fbd@heytings.org> <83y2cu4p0g.fsf@gnu.org> <1a73bd6c6998b2e086fc@heytings.org> <83tuni4mwi.fsf@gnu.org> <1a73bd6c69c2cc8827d5@heytings.org> <83r1im4jct.fsf@gnu.org> <83tunh2xlv.fsf@gnu.org> <83zgx8e15p.fsf@gnu.org> <531453ddd615858f272b@heytings.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: martin rudalics , Eli Zaretskii , 47969@debbugs.gnu.org, robert@capuchin.co.uk To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 16:20:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leerN-0009AF-13 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 16:20:13 +0200 Original-Received: from localhost ([::1]:51838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leerM-0002B3-0i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 10:20:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leerC-00029d-JX for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 10:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leerC-0007o4-Bl for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 10:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leerC-0001AF-6t for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 10:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 14:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47969 X-GNU-PR-Package: emacs Original-Received: via spool by 47969-submit@debbugs.gnu.org id=B47969.16203107454462 (code B ref 47969); Thu, 06 May 2021 14:20:02 +0000 Original-Received: (at 47969) by debbugs.gnu.org; 6 May 2021 14:19:05 +0000 Original-Received: from localhost ([127.0.0.1]:37731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leeqH-00019u-CV for submit@debbugs.gnu.org; Thu, 06 May 2021 10:19:05 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leeqD-00019X-5Y for 47969@debbugs.gnu.org; Thu, 06 May 2021 10:19:04 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9283C8089C; Thu, 6 May 2021 10:18:55 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4FFB280662; Thu, 6 May 2021 10:18:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1620310734; bh=hSVd1jutZ+fzNF7d0/oYtwMaj6OUwHHe6hQOFX5zu8s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XX/vMIjfoAwqBBUHzIV4Xc5briHGuVrJic1tzMP78ELMBBcLpyUm4xcidPIHCu8R3 VvtZr5dkQTJVyJDWfgU1NXDugdpV8MQLHuENBZfdeDcHbESG98YTi9um66PVSibZW0 2/1cBAMCOs1MwElBqwapXgvtq1jv8bY2m5WR9pWpMC3y91XqLJw1BaFWl/udCMg5hV eDJ3kxJS/ByC1sMwFEXkDCxnjF1wZ85jYBunBWT2xm7U0kawJ8k3Jyufn3qdCGqTbH 4uiZiT3SSytNU8q+2Dg0PyxSpT2H3lXBfMKAFDnuC26RLwuXM2gawnP5idfsTDOVMF ZSIviEYL3Jb8g== Original-Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 14E5B1201C1; Thu, 6 May 2021 10:18:54 -0400 (EDT) In-Reply-To: <531453ddd615858f272b@heytings.org> (Gregory Heytings's message of "Thu, 06 May 2021 13:50:48 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205839 Archived-At: > I have one more comment: the code that was removed from handle-select-window > by commit 3fdd3bb56c: > > ;; Don't switch if we're currently in the minibuffer. > ;; This tries to work around problems where the > ;; minibuffer gets unselected unexpectedly, and where > ;; you then have to move your mouse all the way down to > ;; the minibuffer to select it. > (window-minibuffer-p) IIUC this condition was tested when we actually tried to select the other window, i.e. "at the end of `ESC x`". > was added by that same commit in xterm.c: > > /* Don't switch if we're currently in the minibuffer. > This tries to work around problems where the > minibuffer gets unselected unexpectedly, and where > you then have to move your mouse all the way down to > the minibuffer to select it. */ > && !MINI_WINDOW_P (XWINDOW (selected_window)) Whereas this condition is now tested when the mouse movement takes place, i.e. betwen `ESC` and `x`, at which point the minibuffer is not yet activated. Stefan