From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#53526: 29.0.50; macroexp-warn-and-return API change Date: Tue, 25 Jan 2022 11:56:22 -0500 Message-ID: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14946"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie To: 53526@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 25 17:57:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCP8A-0003gG-8k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jan 2022 17:57:18 +0100 Original-Received: from localhost ([::1]:59158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCP89-0003FK-Ao for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jan 2022 11:57:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCP7u-00039r-SW for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 11:57:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCP7u-0002db-HY for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 11:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCP7t-0001G6-Tt; Tue, 25 Jan 2022 11:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: acm@muc.de, bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jan 2022 16:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53526 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Alan Mackenzie Original-Received: via spool by submit@debbugs.gnu.org id=B.16431298124820 (code B ref -1); Tue, 25 Jan 2022 16:57:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Jan 2022 16:56:52 +0000 Original-Received: from localhost ([127.0.0.1]:49926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCP7k-0001Fg-62 for submit@debbugs.gnu.org; Tue, 25 Jan 2022 11:56:52 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:60752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCP7i-0001FX-8D for submit@debbugs.gnu.org; Tue, 25 Jan 2022 11:56:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCP7h-0002mZ-W3 for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 11:56:50 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:44800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCP7U-0002Qr-QI for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 11:56:49 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A3F48805F9 for ; Tue, 25 Jan 2022 11:56:34 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 61A54805CC for ; Tue, 25 Jan 2022 11:56:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1643129793; bh=eETqpFXjSJWnAfWZxzJ+juagNM8adfq93bDbNOub4EE=; h=From:To:Subject:Date:From; b=pht9BNuVBdjjMVmv9yyzKxE3w0FhkzCEeA8yyRrnvE3zFp3V4GqVulxHyyMtb/bER jz80XwUzBVheuFEk2LBh4lGkdjuvNRdEaak/ZVnlf3ErJkI42On/AIy33m26PbJOqr Pn87zc2RD+xXFRD3lcbciXkzsTIHsgoj2t170wWlP1MiOCjfL9dTLSf1pQ0LFB8lDz UaXZVTA3uWNVy2Naltu42NSuqMoWHNNJGOqRFawbGydclm+1OXSJnTgrCd0/a6R7E8 OYlzOETFyrEIKJxM1jzh1//+dqhPZ+oDFU00vaonXjWm7GyCGyOk4zacPGxQLwqb3t 31ZPgVyMl1q0Q== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3EF1F120434 for ; Tue, 25 Jan 2022 11:56:33 -0500 (EST) Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225202 Archived-At: Package: Emacs Version: 29.0.50 The following change in `macroexp.el` on `master` is not backward compatible with the Emacs-28 API: -(defun macroexp-warn-and-return (msg form &optional category compile-only) +(defun macroexp-warn-and-return (arg msg form &optional category compile-only) I suspect that the `arg` should be added at the end instead. While I'm here I also noticed that `byte-compile-form-stack` is a poor name for a variable declared in `macroexp.el`. It should either be renamed to use the `macroexp-` prefix, or moved to `bytecomp.el` (and it probably should have a double-hyphen, since I think it's not meant to be used by anyone but us). Stefan