From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Date: Mon, 28 Feb 2022 08:18:26 -0500 Message-ID: References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31580"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Jim Porter , 54190@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 28 14:20:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOfwk-0007wl-Es for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 14:20:14 +0100 Original-Received: from localhost ([::1]:36186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOfwj-00059A-9h for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 08:20:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOfvb-0004f1-17 for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:19:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOfva-0005Pt-4k for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOfva-0007jX-0j for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Feb 2022 13:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54190-submit@debbugs.gnu.org id=B54190.164605431729696 (code B ref 54190); Mon, 28 Feb 2022 13:19:01 +0000 Original-Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 13:18:37 +0000 Original-Received: from localhost ([127.0.0.1]:60506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOfvA-0007iu-QN for submit@debbugs.gnu.org; Mon, 28 Feb 2022 08:18:37 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOfv8-0007ih-Ua for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 08:18:35 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D5C4B805CC; Mon, 28 Feb 2022 08:18:28 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7D6A380543; Mon, 28 Feb 2022 08:18:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1646054307; bh=JhAvS4EIgtPfBLlxRRb3mvsrbWT1hu5zbqESuWG/CU8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DY/oWnMCgJEXKJCNaoOqnxbujwSnB3TIHRr4oAxUSnOR1kl7aMIcUPuisXBkU2RYV yCgr/2G2rmkY5hfSChY3ShZoeq8nEPjwpoW5qFDcirr23ERrlTcobdZ7SskQiHpWua F9aIwmEy5Nc+HbGvBnrseCVA//PPMVZsQkgr2TcVdrsDjSOC5d3gN+7peh62ZltvTZ RYxxZPSmBu6mPbsXZE5Ia0NnbPWxZdqHQRoDIOO8wljFxeUNDk46nNdwTu5BHYQLsG iyMwv64ASdv6tyfbWnQ1hm6V/caff9NyYgSrZRGu86yBKT8J0lmQQXMfVqIEwNe14c FhrfPUMdDSjMg== Original-Received: from pastel (unknown [45.72.208.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 54CB9120ECC; Mon, 28 Feb 2022 08:18:27 -0500 (EST) In-Reply-To: <87o82rqqjs.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 28 Feb 2022 10:38:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227808 Archived-At: Lars Ingebrigtsen [2022-02-28 10:38:31] wrote: > Jim Porter writes: >> Ok, the breaking commit is b03f74e0f2a578b1580e8b1c368665850ee7f808 >> ("Don't quote lambdas in several places"). Reverting the change in >> that commit in lisp/eshell/esh-var.el fixes things, although I'm not >> sure why yet. I believe that code gets evaluated by `eshell-do-eval', >> which evaluates things in a very particular way in order to support >> deferring evaluation at various points. Once I'm sure I understand why >> this is breaking, I'll post a patch to fix the bustage. > > It's this bit? Hm... > > diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el > index 96838d4132..7388279f15 100644 > --- a/lisp/eshell/esh-var.el > +++ b/lisp/eshell/esh-var.el > @@ -463,8 +463,8 @@ eshell-parse-variable-ref > (eshell-as-subcommand ,(eshell-parse-command cmd)) > (ignore > (nconc eshell-this-command-hook > - (list (function (lambda () > - (delete-file ,temp)))))) > + (list (lambda () > + (delete-file ,temp))))) > (quote ,temp))) > (goto-char (1+ end))))))) > ((eq (char-after) ?\() > > > Trying to follow the logic of how this is eventually evaluated isn't, > er, obvious, but I'm not sure how that change could break anything, > either. Perhaps Stefan has a comment; added to the CCs. Looks like a bug somewhere in the `eshell-do-eval` machinery, yes. Until we find the problem (or rewrite `eshell-do-eval` on top of the CPS converter of `generator.el`), I think reverting this change (and adding a comment pointing to this bug) sounds like a great plan. Stefan