From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros Date: Mon, 05 Sep 2022 22:22:28 -0400 Message-ID: References: <8735eeyz7e.fsf@web.de> <87y1w6xjmg.fsf@web.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4363"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56739@debbugs.gnu.org, Wing Hei Chan To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 04:23:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVOF6-0000xr-5w for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 04:23:12 +0200 Original-Received: from localhost ([::1]:40438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVOF4-0007Fv-BT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Sep 2022 22:23:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVOEw-0007EL-DF for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 22:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVOEw-0004q0-4f for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 22:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVOEv-0004Ip-Kw for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 22:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 02:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56739 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56739-submit@debbugs.gnu.org id=B56739.166243095916509 (code B ref 56739); Tue, 06 Sep 2022 02:23:01 +0000 Original-Received: (at 56739) by debbugs.gnu.org; 6 Sep 2022 02:22:39 +0000 Original-Received: from localhost ([127.0.0.1]:49242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVOEY-0004ID-TH for submit@debbugs.gnu.org; Mon, 05 Sep 2022 22:22:39 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVOEW-0004I0-VC for 56739@debbugs.gnu.org; Mon, 05 Sep 2022 22:22:37 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 252BD100129; Mon, 5 Sep 2022 22:22:31 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BFD331000B9; Mon, 5 Sep 2022 22:22:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662430949; bh=1cyttE2jkm7muGt0gJn2v4Z5wFcJ3QfD+1ULFV8/Vtw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aFvjnAtaX3fcq3EGD6fZMh4CkrvWC4iTIG88oWOO5ppCWwAMYdZeS7wzLfMQe1u3h gRgxyFo7vylheHtln2RPNOqu6T0BBMYYvgWEd3XIFxPkFwd4UVEP2OSIXJo2zTjWbv 08moGQote9o3Gy3Ert/tOmz/fuqZBkOWDpIAiw1dJrMp8JNyOUhxPXKOBYHXX59akI WlUAxYKpAbuTv0F5NPiFdEFrqdh9Ef+bH3z3xc12cVSwLRIFae+X7S6P5vImEvrE8O 4nGNWNOyFSPTq5JifjY87i+RvpgY8juFksFe0xUKpiCMc3ZeRhVtKTX4Ae6GsQALug uW8prNUFUnv8w== Original-Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7DC23120909; Mon, 5 Sep 2022 22:22:29 -0400 (EDT) In-Reply-To: <87y1w6xjmg.fsf@web.de> (Michael Heerdegen's message of "Wed, 03 Aug 2022 02:20:55 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241611 Archived-At: > - (let ((p args) (simple t) (vars nil)) > + (let ((p args) (simple t) (vars nil) > + (smacros (alist-get :cl-symbol-macros macroexpand-all-environment))) > (while p > - (if (or (not (symbolp (car p))) (cl--expr-depends-p (nth 1 p) vars)) > - (setq simple nil)) > - (if (memq (car p) vars) > - (error "Destination duplicated in psetf: %s" (car p))) > + (when (or (not (symbolp (car p))) > + (assq (car p) smacros) This looks like a safe way to make it work when the place is a symbol macro. > + (and (symbolp (nth 1 p)) > + (assq (nth 1 p) smacros)) > + (cl--expr-depends-p (nth 1 p) vars)) But this doesn't look strong enough; if (nth 1 p) is (+ c c) where `c` is a symbol macro the same problem will appear. So the test needs to be pushed into `cl--expr-depends-p` (probably into `cl--safe-expr-p` where it will fix other related problems elsewhere). Stefan