From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60237: 30.0.50; tree sitter core dumps when I edebug view a node Date: Thu, 02 Mar 2023 15:24:07 -0500 Message-ID: References: <9FCDA5B7-D216-45B1-8051-35B05633BEFB@gmail.com> <83sfeukwsb.fsf@gnu.org> <574817C4-3FD8-43EA-B53C-B2BCB60A6D0A@gmail.com> <83mt51j6mv.fsf@gnu.org> <83a60xhou5.fsf@gnu.org> <83mt4wfvpd.fsf@gnu.org> <871qm7zojx.fsf@yahoo.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20057"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , mickey@masteringemacs.org, casouri@gmail.com, 60237@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 02 21:25:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXpUO-00052P-UH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Mar 2023 21:25:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXpU8-00037Z-Mi; Thu, 02 Mar 2023 15:25:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXpU6-00037J-KN for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 15:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXpU6-0004h1-8w for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 15:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXpU5-0000Yx-Nr for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 15:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2023 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60237 X-GNU-PR-Package: emacs Original-Received: via spool by 60237-submit@debbugs.gnu.org id=B60237.16777886592096 (code B ref 60237); Thu, 02 Mar 2023 20:25:01 +0000 Original-Received: (at 60237) by debbugs.gnu.org; 2 Mar 2023 20:24:19 +0000 Original-Received: from localhost ([127.0.0.1]:58463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXpTO-0000Xk-St for submit@debbugs.gnu.org; Thu, 02 Mar 2023 15:24:19 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXpTN-0000XW-7Y for 60237@debbugs.gnu.org; Thu, 02 Mar 2023 15:24:17 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 65A0380087; Thu, 2 Mar 2023 15:24:11 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 54E81800AE; Thu, 2 Mar 2023 15:24:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1677788649; bh=FNov4R2aFZSNzJCxWvbWjU+1og15giQk37Rna2gZzSw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AqgiBzeNrWlhTCdosiOmndZbYCS5T4q16vPIM2yXq1WmNfIf0cCW0i1rHyR792bn/ VPZLT0s+NqnpAKv1ilyosXWKcRE5jhBpTJarXHuzqC7PylV+H4Hig/ZUIPCpwN7voF 6WX6FvGZmz6bc5+KeSA7Y0Bd2xbPaPT/8TwtnLjoOHEe4/NnA+7HG56seB2bYl4bgG Fy/NSoNpJC6TclI+uccSPq/qCNnEx4JDUVj9SVr+Y9CLINySHWkfUzmCj6KE4NGcBl MAIT1wCM5hictLAbHD8ghif5M0odAKqCqoDcj/PGcAd1tLAstI7OyQbYdIWEZqEOYN 6pWcY3Syd1R0w== Original-Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 160DD123199; Thu, 2 Mar 2023 15:24:09 -0500 (EST) In-Reply-To: <871qm7zojx.fsf@yahoo.com> (Po Lu's message of "Thu, 02 Mar 2023 13:53:54 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257179 Archived-At: >> diff --git a/src/profiler.c b/src/profiler.c >> index 81b5e7b0cf0..c99ed0a81a2 100644 >> --- a/src/profiler.c >> +++ b/src/profiler.c >> @@ -505,6 +505,8 @@ DEFUN ("profiler-memory-log", >> void >> malloc_probe (size_t size) >> { >> + if (EQ (backtrace_top_function (), QAutomatic_GC)) >> + return; /* bug#60237 */ >> eassert (HASH_TABLE_P (memory_log)); >> record_backtrace (XHASH_TABLE (memory_log), min (size, MOST_POSITIVE_FIXNUM)); >> } > > Shouldn't this be: > > if (gc_in_progress) > return; Sounds like a good idea. If so that should apply to the cpu profiler code as well. It might be worthwhile to check the details to see if there might be subtle differences (e.g. when we're running `post-gc-hook` maybe?). Stefan