bug#5304: Subject: 23.1.91; comment-start in fundamental-mode

bug#5304: Subject: 23.1.91; comment-start in fundamental-mode

[Andreas Roehler]

Hi,

after emacs -q
`comment-start' is available in fundamental mode as a global variable.
Once set, it retains its value for other buffers.

IMO `comment-start' should not exist in fundamental mode,
also it should be buffer local from the very beginning.

Below a recipe to reproduce the bug:

emacs -q
scratch-buffer
M-x fundamental-mode
\C-h v comment-start

==>

comment-start is a variable defined in `newcomment.el'.
Its value is nil

  This variable is safe as a file local variable if its value
  satisfies the predicate `string-or-null-p'.

Documentation:
*String to insert to start a new comment, or nil if no comment syntax.

;;;;;;;;;;;;

(setq comment-start "abc")
\C-h v comment-start

==>

comment-start is a variable defined in `newcomment.el'.
Its value is "abc"

...

;;;;;;;;;;;;;

Now kill buffer, ask again: same result.
`comment-start' is remembered throughout buffers as "abc".

So far, thanks all

Andreas

BTW emacs-pretest-bug@gnu.org still active, think it should be deactivated(?)

--
https://code.launchpad.net/s-x-emacs-werkstatt/

;;;;;;;;;;;;;;;;;;;;;;;;

In GNU Emacs 23.1.91.1 (i686-pc-linux-gnu, GTK+ Version 2.12.0)
 of 2010-01-01
Windowing system distributor `The X.Org Foundation', version 11.0.70200000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-h v c o m m e n t - s r <backspace> t a r t <return>
M-x f u n d a m e n t a l - m o <tab> <return> C-h
v <up> <return> M-x r e p o r t - e m a c s - b u <tab>
<return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-x 1 to delete the help window.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message sendmail regexp-opt ecomplete rfc822 mml
mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse
rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util
netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock
sha1 hex-util hashcash mail-utils emacsbug pp find-func help-mode
easymenu view help-fns tooltip ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev loaddefs button minibuffer faces cus-face files text-properties
overlay md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs)

bug#5304: Subject: 23.1.91; comment-start in fundamental-mode

[Stefan Monnier]

> (setq comment-start "abc")

If you want to set it buffer-locally, then set it buffer-locally:

  (set (make-local-variable 'comment-start) "abc")

Same goes for most other variables.


        Stefan

bug#5304: Subject: 23.1.91; comment-start in fundamental-mode

[Andreas Roehler]

Stefan Monnier wrote:
>> (setq comment-start "abc")
> 
> If you want to set it buffer-locally, then set it buffer-locally:
> 
>   (set (make-local-variable 'comment-start) "abc")
> 
> Same goes for most other variables.
> 
> 
>         Stefan
> 

Stumbled over the issue from my
line-or-region commenting tool - with prefix `ar-' now
BTW at

https://code.launchpad.net/s-x-emacs-werkstatt/

lisp-mode.el contains this

  (make-local-variable 'comment-start)
  (setq comment-start ";")

Think that's the right place: it's more straight IMHO let
modes introduce this var.

Maybe just delete it from c-sources? Unless I'm missing
something... :-)

Thanks

Andreas