From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Thu, 23 Feb 2012 12:18:51 -0500 Message-ID: References: <87mx9su32g.fsf@web.de> <87mx9q1sz7.fsf@gmail.com> <87vcodm8ns.fsf@gmx.de> <87pqekopb5.fsf@gmail.com> <87hazwoost.fsf@gmail.com> <87ty3w9639.fsf@gmx.de> <8762gckckt.fsf@gmail.com> <87pqek9269.fsf@gmx.de> <87r4z0yqfx.fsf@gmail.com> <871uqzn3bc.fsf@gmx.de> <871uqz651u.fsf@gmx.de> <87pqd89lh4.fsf@gmail.com> <87mx8b3nvb.fsf@gmail.com> <87pqd6wnvv.fsf@gmail.com> <87d395y1w0.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1330017589 7537 80.91.229.3 (23 Feb 2012 17:19:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Feb 2012 17:19:49 +0000 (UTC) Cc: 10489@debbugs.gnu.org, Michael Albinus To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 23 18:19:46 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S0cKW-0006gU-Q7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Feb 2012 18:19:44 +0100 Original-Received: from localhost ([::1]:58554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0cKW-0002Sp-7A for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Feb 2012 12:19:44 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:37952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0cKO-0002Rl-HV for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2012 12:19:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0cKL-0005pb-Cx for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2012 12:19:36 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0cKL-0005pW-44 for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2012 12:19:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S0cMj-0000W3-OH for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2012 12:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Feb 2012 17:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.13300176901941 (code B ref 10489); Thu, 23 Feb 2012 17:22:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 23 Feb 2012 17:21:30 +0000 Original-Received: from localhost ([127.0.0.1]:52933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0cME-0000VG-6f for submit@debbugs.gnu.org; Thu, 23 Feb 2012 12:21:30 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:35228) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0cMA-0000V0-TL for 10489@debbugs.gnu.org; Thu, 23 Feb 2012 12:21:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoIFAKU/KE9Ld/XJ/2dsb2JhbACBX4I9mj55iHCXTYZMgSuDZ4EHBIZQlEmECw X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="164341416" Original-Received: from 75-119-245-201.dsl.teksavvy.com (HELO pastel.home) ([75.119.245.201]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Feb 2012 12:18:51 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7E5D158EC6; Thu, 23 Feb 2012 12:18:51 -0500 (EST) In-Reply-To: <87d395y1w0.fsf@gmail.com> (Thierry Volpiatto's message of "Thu, 23 Feb 2012 17:01:51 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57142 Archived-At: > Here a first shot of `copy-directory', with the first check disabled > (file-subdir-of-p) to test the detection of the inf-loop, can you have a > look? I think we can install the file-subdir-of-p test now and leave the rest for 24.2. Can you (re)send the corresponding patch? Note that (or (files-equal-p directory newname) (file-subdir-of-p newname directory)) should be replaced by just (file-subdir-of-p newname directory), because this primitive should be a "=E2=8A=86" rather than "=E2=8A=82". > --8<---------------cut here---------------start------------->8--- I always prefer a patch rather than the resulting code, so I don't have to look for the source code to see what's changed. Stefan