From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@gnu.org>
Cc: 11506-done@debbugs.gnu.org
Subject: bug#11506: bug: "C-x z" ("repeat") no longer works correctly with M-x
Date: Sat, 02 Jun 2012 15:21:51 -0400 [thread overview]
Message-ID: <jwv396dfunw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <8762ba8b6p.fsf@gnu.org> (Chong Yidong's message of "Sat, 02 Jun 2012 14:44:46 +0800")
> The problem is that the old execute-extended-command sets the
> real_this_command internal variable, which causes the Emacs command loop
> to record the command that was actually executed into real-last-command
> and last-repeatable-command.
Indeed.
> In other words, it's not just the fact that `C-x z' doesn't work
> properly. Moving execute-extended-command to Lisp produces a
> backward-incompatible change in the values of the real-last-command and
> last-repeatable-command variables for M-x. I suspect this may break
> things other than `C-x z'. I guess we could fix this by exposing
> real_this_command to Lisp too, but that kinda defeats the point of that
> variable...
I don't see why this would defeat anything. Clearly,
execute-extended-command demonstrates that there can be very good
reasons to change real-this-command.
I installed a change that does just that.
> Is there a strong rationale for moving execute-extended-command to Lisp,
> other than the general principle that we want as much functionality
> implemented Lisp as possible?
To me, an important part of moving code to Elisp is to make sure that it
*can* be implemented in Elisp (i.e. that some third-party package can
provide a new implementation of that functionality).
Stefan
next parent reply other threads:[~2012-06-02 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87396ylx5m.fsf@catnip.gol.com>
[not found] ` <87pq9ndq0n.fsf@gnu.org>
[not found] ` <CAFw1JJ5ptxbaSw8COXna-tZJfQL17YSWAAAj81rSwnEDKpgUcQ@mail.gmail.com>
[not found] ` <8762ba8b6p.fsf@gnu.org>
2012-06-02 19:21 ` Stefan Monnier [this message]
[not found] ` <4DDFBCA4D529431F922887DF34538295@us.oracle.com>
[not found] ` <jwvvcj9cc32.fsf-monnier+emacs@gnu.org>
[not found] ` <702924CEED3B405D81D118DDE532C97F@us.oracle.com>
[not found] ` <jwv8vg4ctjl.fsf-monnier+emacs@gnu.org>
2012-06-04 13:47 ` bug#11506: bug: "C-x z" ("repeat") no longer works correctly with M-x Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv396dfunw.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11506-done@debbugs.gnu.org \
--cc=cyd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).