unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Takafumi Arakaki <aka.tkf@gmail.com>
Cc: 12597-done@debbugs.gnu.org
Subject: bug#12597: 24.2.50; Cannot exit read-passwd by C-j/C-m/<return>
Date: Sun, 07 Oct 2012 15:34:55 -0400	[thread overview]
Message-ID: <jwv391q2i2x.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87fw5q2p9e.fsf@gmail.com> (Takafumi Arakaki's message of "Sun, 07 Oct 2012 18:58:05 +0200")

> Type M-: (read-passwd "> ") RET
> then you cannot finish the prompt by C-j nor C-m nor <return>.
> The only when I found is C-M-c (exit-recursive-edit).  This
> effects for example when typing password to send email using smtpmail.
> This is strange because minibuffer-local-map (parent of read-passwd-map)
> defines exit-minibuffer.

Thanks for the heads up.  Indeed, it got me stumped for a while until
I realized that defconst behaves funny during the dump (it purecopy's
its argument, so we get a snapshot of minibuffer-local-map, taken
before minibuffer-local-map has been populated).
I installed the patch below which seems to fix the problem,


        Stefan


--- lisp/subr.el	2012-10-06 17:29:15 +0000
+++ lisp/subr.el	2012-10-07 19:31:03 +0000
@@ -2143,7 +2143,9 @@
       (setq first nil))
     code))
 
-(defconst read-passwd-map
+(defvar read-passwd-map
+  ;; BEWARE: `defconst' would purecopy it, breaking the sharing with
+  ;; minibuffer-local-map along the way!
   (let ((map (make-sparse-keymap)))
     (set-keymap-parent map minibuffer-local-map)
     (define-key map "\C-u" #'delete-minibuffer-contents) ;bug#12570





      reply	other threads:[~2012-10-07 19:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-07 16:58 bug#12597: 24.2.50; Cannot exit read-passwd by C-j/C-m/<return> Takafumi Arakaki
2012-10-07 19:34 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv391q2i2x.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=12597-done@debbugs.gnu.org \
    --cc=aka.tkf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).