From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13432: 24.2; File does not get saved when save-buffer called Date: Sun, 13 Jan 2013 20:38:56 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1358127599 26385 80.91.229.3 (14 Jan 2013 01:39:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Jan 2013 01:39:59 +0000 (UTC) Cc: 13432-done@debbugs.gnu.org To: Peter Milliken Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 14 02:40:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TuZ23-0001BO-CM for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jan 2013 02:40:11 +0100 Original-Received: from localhost ([::1]:47815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuZ1m-0003dP-Uk for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jan 2013 20:39:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuZ1g-0003dB-3u for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 20:39:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuZ1b-0007kz-F0 for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 20:39:48 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuZ1b-0007kp-C9 for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 20:39:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TuZ1w-00035A-6b for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 20:40:04 -0500 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Jan 2013 01:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 13432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Mail-Followup-To: 13432@debbugs.gnu.org, monnier@iro.umontreal.ca, peter.milliken@gmail.com Original-Received: via spool by 13432-done@debbugs.gnu.org id=D13432.135812756811785 (code D ref 13432); Mon, 14 Jan 2013 01:40:03 +0000 Original-Received: (at 13432-done) by debbugs.gnu.org; 14 Jan 2013 01:39:28 +0000 Original-Received: from localhost ([127.0.0.1]:58902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TuZ1M-000341-0d for submit@debbugs.gnu.org; Sun, 13 Jan 2013 20:39:28 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:47154) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TuZ1I-00033l-Fr; Sun, 13 Jan 2013 20:39:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtkGAG6Zu09FpZpV/2dsb2JhbABEgXuyFoEIghYBBVYjEAs0EhQYDSSIIboJkEQDiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="212446044" Original-Received: from 69-165-154-85.dsl.teksavvy.com (HELO pastel.home) ([69.165.154.85]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Jan 2013 20:38:57 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 2FBAE58A07; Sun, 13 Jan 2013 20:38:56 -0500 (EST) In-Reply-To: (Peter Milliken's message of "Mon, 14 Jan 2013 09:40:55 +1100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69749 Archived-At: tags 13432 notabug thanks > (defadvice python-mode (after minor-modes-for-python activate compile) > (add-hook 'local-write-file-hooks > '(lambda () (untabify (point-min) (point-max))))) As Glenn explains, this is not a bug. It's probably due to a change in untabify which now returns a different value, but since the return value of untabify is undocumented, this is not a bug/regression. But while I'm here, I'll point out a few improvement to your above code: - don't quote lambda. - use python-mode-hook rather than defadvice. - use before-save-hook rather than local-write-file-hooks (this will also fix your problem). I.e. (add-hook 'python-mode-hook (lambda () (add-hook 'before-save-hook (lambda () (untabify (point-min) (point-max))) nil 'local))) -- Stefan