From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 13831@debbugs.gnu.org
Subject: bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function
Date: Fri, 01 Mar 2013 09:29:23 -0500 [thread overview]
Message-ID: <jwv38wfgptp.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zjyny54l.fsf@gmail.com> (Thierry Volpiatto's message of "Fri, 01 Mar 2013 08:02:34 +0100")
> Here your patch modified, I have simplified
> `net-utils-remove-ctrl-m-filter'.
Actually, my patch is already in the trunk. Could you make the patch
relative to trunk's version?
> + (save-selected-window
> + (set-buffer (process-buffer process))
> + (save-excursion
> + (let ((inhibit-read-only t)
> + (filtered-string output-string))
> + (while (string-match "\r" filtered-string)
> + (setq filtered-string
> + (replace-match "" nil nil filtered-string)))
> + ;; Insert the text, moving the process-marker.
> + (goto-char (process-mark process))
> + (insert filtered-string)
> + (set-marker (process-mark process) (point))))))
This code does not affect the selected-window, so there shouldn't be any
save-selected-window. Instead it should use with-current-buffer.
BTW, I think the desired behavior is not the same for all net-utils
tools. E.g. for ping, we'd like point to stay at the end. So you above
change is good but it should be completed with changes in the relevant
commands to set window-point-insertion-type when necessary.
Stefan
next prev parent reply other threads:[~2013-03-01 14:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 9:30 bug#13831: 24.3.50; [PATCH] net-utils-mode have no revert-buffer function Thierry Volpiatto
2013-02-27 9:48 ` Thierry Volpiatto
2013-02-27 10:11 ` Andreas Schwab
2013-02-27 10:50 ` Thierry Volpiatto
2013-02-27 11:57 ` Andreas Schwab
2013-02-27 12:03 ` Thierry Volpiatto
2013-02-27 14:08 ` Stefan Monnier
2013-02-27 14:35 ` Thierry Volpiatto
2013-02-27 15:25 ` Stefan Monnier
2013-02-27 16:36 ` Thierry Volpiatto
2013-02-28 4:51 ` Stefan Monnier
2013-02-28 6:18 ` Thierry Volpiatto
2013-02-28 14:04 ` Stefan Monnier
2013-02-28 19:45 ` Thierry Volpiatto
2013-03-01 3:05 ` Stefan Monnier
2013-03-01 7:02 ` Thierry Volpiatto
2013-03-01 14:29 ` Stefan Monnier [this message]
2013-03-01 15:22 ` Thierry Volpiatto
2013-03-01 17:28 ` Stefan Monnier
2013-03-01 19:07 ` Thierry Volpiatto
2013-03-11 18:31 ` Stefan Monnier
2013-03-13 14:43 ` Thierry Volpiatto
2013-03-13 17:52 ` Stefan Monnier
2013-03-13 20:12 ` Thierry Volpiatto
2013-03-03 6:16 ` Thierry Volpiatto
2013-03-01 14:30 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv38wfgptp.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13831@debbugs.gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).