From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14718: 24.3.50; Endless loop in "package-read-all-archive-contents" Date: Tue, 25 Jun 2013 20:45:36 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372207573 16603 80.91.229.3 (26 Jun 2013 00:46:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Jun 2013 00:46:13 +0000 (UTC) Cc: 14718@debbugs.gnu.org To: Sebastian Wiesner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 02:46:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrdsB-0000o9-Nf for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2013 02:46:11 +0200 Original-Received: from localhost ([::1]:45164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrdsB-0007Z5-Ci for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2013 20:46:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urds7-0007V9-1U for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 20:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Urds1-0005nm-Vk for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 20:46:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Urds1-0005ni-TV for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 20:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Urds1-0000Fm-Mx for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 20:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2013 00:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14718 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14718-submit@debbugs.gnu.org id=B14718.1372207546931 (code B ref 14718); Wed, 26 Jun 2013 00:46:01 +0000 Original-Received: (at 14718) by debbugs.gnu.org; 26 Jun 2013 00:45:46 +0000 Original-Received: from localhost ([127.0.0.1]:41374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Urdrl-0000Er-9l for submit@debbugs.gnu.org; Tue, 25 Jun 2013 20:45:45 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:4976) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Urdrj-0000EY-36 for 14718@debbugs.gnu.org; Tue, 25 Jun 2013 20:45:43 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCppA/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJBOICwaxH5AOkQoDklsDkhyBXoMT X-IPAS-Result: Av4EABK/CFFMCppA/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJBOICwaxH5AOkQoDklsDkhyBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17169683" Original-Received: from 76-10-154-64.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Jun 2013 20:45:31 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C81A4678F1; Tue, 25 Jun 2013 20:45:36 -0400 (EDT) In-Reply-To: (Sebastian Wiesner's message of "Tue, 25 Jun 2013 22:19:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75598 Archived-At: > If a package is contained in two or more archives, > "package-read-all-archive-contents" hangs in an endless loop. For > instance, in "emacs -Q": Duh! Not sure how the nil got lost when I copied the loop from package-process-define-package. I installed the patch below which should fix it, Stefan === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2013-06-25 16:13:49 +0000 +++ lisp/ChangeLog 2013-06-26 00:43:32 +0000 @@ -1,3 +1,8 @@ +2013-06-26 Stefan Monnier + + * emacs-lisp/package.el (package--add-to-archive-contents): Add missing + nil terminate the loop (bug#14718). + 2013-06-25 Stefan Monnier * emacs-lisp/package.el: Use lexical-binding. Include obsolete === modified file 'lisp/emacs-lisp/package.el' --- lisp/emacs-lisp/package.el 2013-06-25 16:13:49 +0000 +++ lisp/emacs-lisp/package.el 2013-06-26 00:42:56 +0000 @@ -3,6 +3,7 @@ ;; Copyright (C) 2007-2013 Free Software Foundation, Inc. ;; Author: Tom Tromey +;; Daniel Hackney ;; Created: 10 Mar 2007 ;; Version: 1.0.1 ;; Keywords: tools @@ -924,7 +925,8 @@ (version-list-< version (package-desc-version (cadr existing-packages)))) (setq existing-packages (cdr existing-packages)) - (push pkg-desc (cdr existing-packages)))))))) + (push pkg-desc (cdr existing-packages)) + nil)))))) (defun package-download-transaction (packages) "Download and install all the packages in PACKAGES.