From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Sebastian Wiesner <lunaryorn@gmail.com>
Cc: 14718@debbugs.gnu.org
Subject: bug#14718: 24.3.50; Endless loop in "package-read-all-archive-contents"
Date: Tue, 25 Jun 2013 20:45:36 -0400 [thread overview]
Message-ID: <jwv38s5aef7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m261x2x7s0.fsf@gmail.com> (Sebastian Wiesner's message of "Tue, 25 Jun 2013 22:19:43 +0200")
> If a package is contained in two or more archives,
> "package-read-all-archive-contents" hangs in an endless loop. For
> instance, in "emacs -Q":
Duh! Not sure how the nil got lost when I copied the loop from
package-process-define-package.
I installed the patch below which should fix it,
Stefan
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2013-06-25 16:13:49 +0000
+++ lisp/ChangeLog 2013-06-26 00:43:32 +0000
@@ -1,3 +1,8 @@
+2013-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
+
+ * emacs-lisp/package.el (package--add-to-archive-contents): Add missing
+ nil terminate the loop (bug#14718).
+
2013-06-25 Stefan Monnier <monnier@iro.umontreal.ca>
* emacs-lisp/package.el: Use lexical-binding. Include obsolete
=== modified file 'lisp/emacs-lisp/package.el'
--- lisp/emacs-lisp/package.el 2013-06-25 16:13:49 +0000
+++ lisp/emacs-lisp/package.el 2013-06-26 00:42:56 +0000
@@ -3,6 +3,7 @@
;; Copyright (C) 2007-2013 Free Software Foundation, Inc.
;; Author: Tom Tromey <tromey@redhat.com>
+;; Daniel Hackney <dan@haxney.org>
;; Created: 10 Mar 2007
;; Version: 1.0.1
;; Keywords: tools
@@ -924,7 +925,8 @@
(version-list-<
version (package-desc-version (cadr existing-packages))))
(setq existing-packages (cdr existing-packages))
- (push pkg-desc (cdr existing-packages))))))))
+ (push pkg-desc (cdr existing-packages))
+ nil))))))
(defun package-download-transaction (packages)
"Download and install all the packages in PACKAGES.
prev parent reply other threads:[~2013-06-26 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 20:19 bug#14718: 24.3.50; Endless loop in "package-read-all-archive-contents" Sebastian Wiesner
2013-06-26 0:45 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv38s5aef7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14718@debbugs.gnu.org \
--cc=lunaryorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).