From: Stefan Monnier <monnier@iro.umontreal.ca>
To: dieter@schoen.or.at
Cc: 17616@debbugs.gnu.org
Subject: bug#17616: patch for svg-clock.el
Date: Sat, 31 May 2014 22:04:45 -0400 [thread overview]
Message-ID: <jwv38fpjsrz.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <f565bb9.4338ffb1617db5203513528aeecdd26c@afterlogic.edis.at> (dieter@schoen.or.at's message of "Wed, 28 May 2014 11:24:19 +0000 (GMT)")
> I found that because svg-clock calls (image-mode) every second, the message
> "Type C-c C-c to view the image as an image." is displayed at the bottom of
[...]
> --- a/packages/svg-clock/svg-clock.el
> +++ b/packages/svg-clock/svg-clock.el
> @@ -186,7 +186,7 @@ TIME must have the form (SECOND MINUTE HOUR ...), asreturned by `decode-time'."
> (svg-clock-replace "%SIZE%" (format "%d" svg-clock--actual-size))
> (svg-clock-replace "%SCALE%"
> (format "%f" (/ svg-clock--actual-size 100.0)))
> - (image-mode)
> - (image-toggle-display-image))))
> + (when (derived-mode-p 'image-mode)
> + (image-toggle-display-image)))))
> (defun svg-clock-update ()
> "Update the clock."
> @@ -245,4 +245,5 @@ Optionally PERFORM-UPDATE immediately."
> (setq svg-clock-timer
> (run-with-timer 0 1 'svg-clock-update))
> (svg-clock-mode)
> + (image-mode)
> (message "Clock started")))
Your patch was quite mangled, please try to use software that does mess
it up so badly next time. In any case I installed it into the `elpa'
branch, thank you.
Stefan
next prev parent reply other threads:[~2014-06-01 2:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 11:24 bug#17616: patch for svg-clock.el dieter
2014-06-01 2:04 ` Stefan Monnier [this message]
2014-06-01 7:31 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv38fpjsrz.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17616@debbugs.gnu.org \
--cc=dieter@schoen.or.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).