From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20357: 25.0.50; deactivate-mark behavior broken Date: Fri, 17 Apr 2015 10:31:32 -0400 Message-ID: References: <87pp735a42.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1429281683 16917 80.91.229.3 (17 Apr 2015 14:41:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Apr 2015 14:41:23 +0000 (UTC) Cc: 20357-done@debbugs.gnu.org To: Oleh Krehel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 17 16:41:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yj7SC-0001GH-KJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Apr 2015 16:41:12 +0200 Original-Received: from localhost ([::1]:41829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj7SB-0004A2-WC for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Apr 2015 10:41:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj7JO-0005AI-A1 for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 10:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj7JL-0006L1-24 for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 10:32:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj7JL-0006Ku-0D for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 10:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yj7JK-00056o-OI for bug-gnu-emacs@gnu.org; Fri, 17 Apr 2015 10:32:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Apr 2015 14:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 20357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 20357@debbugs.gnu.org, monnier@IRO.UMontreal.CA, ohwoeowho@gmail.com Original-Received: via spool by 20357-done@debbugs.gnu.org id=D20357.142928109219557 (code D ref 20357); Fri, 17 Apr 2015 14:32:02 +0000 Original-Received: (at 20357-done) by debbugs.gnu.org; 17 Apr 2015 14:31:32 +0000 Original-Received: from localhost ([127.0.0.1]:59090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj7Ip-00055K-N2 for submit@debbugs.gnu.org; Fri, 17 Apr 2015 10:31:31 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35283) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yj7In-00055A-Tl for 20357-done@debbugs.gnu.org; Fri, 17 Apr 2015 10:31:30 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3HEVS7F005420; Fri, 17 Apr 2015 10:31:28 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 112156610A; Fri, 17 Apr 2015 10:31:32 -0400 (EDT) In-Reply-To: <87pp735a42.fsf@gmail.com> (Oleh Krehel's message of "Fri, 17 Apr 2015 12:21:01 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5279=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5279> : inlines <2743> : streams <1424004> : uri <1909127> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101626 Archived-At: > (let (deactivate-mark) > (indent-region (region-beginning) > (region-end))) > Expected behavior: the mark isn't deactivated. > Actual behavior: the mark is deactivated. Oops, indeed. Fixed with the patch below, Stefan diff --git a/lisp/indent.el b/lisp/indent.el index 74e73a6..18c1fd4 100644 --- a/lisp/indent.el +++ b/lisp/indent.el @@ -537,7 +537,7 @@ column to indent to; if it is nil, use one of the three methods above." ;; In most cases, reindenting modifies the buffer, but it may also ;; leave it unmodified, in which case we have to deactivate the mark ;; by hand. - (deactivate-mark)) + (setq deactivate-mark t)) (defun indent-relative-maybe () "Indent a new line like previous nonblank line.