From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 20608@debbugs.gnu.org
Subject: bug#20608: 25.0.50; vc-git-log-view-mode inserts "Show 2X entries" at bob when interrupted
Date: Wed, 27 May 2015 12:26:48 -0400 [thread overview]
Message-ID: <jwv382i9ecs.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <5565D145.3040606@yandex.ru> (Dmitry Gutov's message of "Wed, 27 May 2015 17:14:29 +0300")
> Any reservations about this patch?
Assuming it works, LGTM,
Stefan
> diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el
> index a2c1cba..ec55867 100644
> --- a/lisp/vc/vc-dispatcher.el
> +++ b/lisp/vc/vc-dispatcher.el
> @@ -171,6 +171,12 @@ Another is that undo information is not kept."
> (let ((camefrom (current-buffer))
> (olddir default-directory))
> (set-buffer (get-buffer-create buf))
> + (let ((oldproc (get-buffer-process (current-buffer))))
> + ;; If we wanted to wait for oldproc to finish before doing
> + ;; something, we'd have used vc-eval-after.
> + ;; Use `delete-process' rather than `kill-process' because we don't
> + ;; want any of its output to appear from now on.
> + (when oldproc (delete-process oldproc)))
> (kill-all-local-variables)
> (set (make-local-variable 'vc-parent-buffer) camefrom)
> (set (make-local-variable 'vc-parent-buffer-name)
> @@ -302,12 +308,6 @@ case, and the process object in the asynchronous case."
> (eq buffer (current-buffer)))
> (vc-setup-buffer buffer))
> ;; If there's some previous async process still running, just
> kill it.
> - (let ((oldproc (get-buffer-process (current-buffer))))
> - ;; If we wanted to wait for oldproc to finish before doing
> - ;; something, we'd have used vc-eval-after.
> - ;; Use `delete-process' rather than `kill-process' because we don't
> - ;; want any of its output to appear from now on.
> - (when oldproc (delete-process oldproc)))
> (let ((squeezed (remq nil flags))
> (inhibit-read-only t)
> (status 0))
next prev parent reply other threads:[~2015-05-27 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 11:43 bug#20608: 25.0.50; vc-git-log-view-mode inserts "Show 2X entries" at bob when interrupted Dmitry Gutov
2015-05-19 13:01 ` martin rudalics
2015-05-19 13:03 ` Dmitry Gutov
2015-05-19 17:40 ` Stefan Monnier
2015-05-24 21:42 ` Dmitry Gutov
2015-05-25 2:57 ` Stefan Monnier
2015-05-25 23:41 ` Dmitry Gutov
2015-05-26 20:53 ` Stefan Monnier
2015-05-27 14:14 ` Dmitry Gutov
2015-05-27 16:26 ` Stefan Monnier [this message]
2015-05-27 23:29 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv382i9ecs.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=20608@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).