unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alan Mackenzie <acm@muc.de>, 23827@debbugs.gnu.org
Subject: bug#23827: 25.1.50; tab-width file-local variable has no effect in etc/HELLO
Date: Fri, 24 Jun 2016 10:12:10 -0400	[thread overview]
Message-ID: <jwv37o2d6hk.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83vb0y1zsb.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 24 Jun 2016 16:28:52 +0300")

> LGTM, but I'm not an expert on modes.  I'd like to hear opinions from
> others.  Stefan?

set-buffer-major-mode and the question about when it's supposed to be
run (and when not), and what it's supposed to do (and how that
interacts with default-major-mode) is still pretty nebulous to
me, sorry.

I tend to agree that it "looks right", so we should probably just
install it into master and see what breaks.  My only real worry is
whether that would end up calling fundamental-mode when creating
temporary buffers such as in `with-temp-buffer' (where we wouldn't want
to run-mode-hooks and hack-local-variables).


        Stefan





  reply	other threads:[~2016-06-24 14:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22 17:05 bug#23827: 25.1.50; tab-width file-local variable has no effect in etc/HELLO Eli Zaretskii
     [not found] ` <mailman.2018.1466615229.1216.bug-gnu-emacs@gnu.org>
2016-06-24 11:07   ` Alan Mackenzie
2016-06-24 13:28     ` Eli Zaretskii
2016-06-24 14:12       ` Stefan Monnier [this message]
2016-06-24 14:17         ` Eli Zaretskii
2016-06-24 14:27           ` Stefan Monnier
2016-06-24 16:09             ` Alan Mackenzie
2016-06-25  0:21               ` Stefan Monnier
2016-06-27 12:52                 ` Alan Mackenzie
2016-06-27 22:03                   ` Stefan Monnier
2016-06-28 10:10                     ` Alan Mackenzie
2016-06-28 21:43                       ` Stefan Monnier
2016-06-30  9:22                         ` Alan Mackenzie
2016-06-30 22:37                           ` Stefan Monnier
2016-06-30 22:39                           ` Stefan Monnier
2016-10-10 10:37                             ` Eli Zaretskii
2016-10-15 14:07                               ` Eli Zaretskii
2016-06-24 16:35 ` Leo Liu
     [not found] ` <mailman.2101.1466786228.1216.bug-gnu-emacs@gnu.org>
2016-06-24 17:17   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv37o2d6hk.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=23827@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).