From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Mark Oteiza <mvoteiza@udel.edu>
Cc: 25400@debbugs.gnu.org
Subject: bug#25400: M-p in diff-mode jumps too far
Date: Sun, 08 Jan 2017 23:34:52 -0500 [thread overview]
Message-ID: <jwv37gsyhvk.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87h959t9n3.fsf@udel.edu> (Mark Oteiza's message of "Sun, 08 Jan 2017 18:27:44 -0500")
>> In a buffer with more than one hunk, if I'm in the middle of hunk number
>> N, diff-hunk-prev (usually bound to M-p) jumps to the header of hunk
>> number N-1 rather than to the header of hunk N.
>>
>> This is contrary to the usual behavior of Emacs's navigation commands.
> Implemented in 2c8a7e5 (bug#17544). Apparently it was intended.
> https://lists.gnu.org/archive/html/emacs-devel/2016-12/msg00222.html
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25105
Maybe it's OK to change the behavior of `diff-hunk-prev` this way when
called from Elisp (I still find it odd, but it might work better for
the callers), but it's clearly not a good idea for M-p to behave
this way.
As pointed out elsewhere, it's particularly obnoxious from EOB (in which
case, you're not really "within N" but you're virtually on "the header
of the non-existent hunk N+1", so going to the header of N-1 is really
wrong).
I also dislike the fact that M-n doesn't let me get to EOB.
Stefan
next prev parent reply other threads:[~2017-01-09 4:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 21:21 bug#25400: M-p in diff-mode jumps too far Stefan Monnier
2017-01-08 23:27 ` Mark Oteiza
2017-01-09 4:34 ` Stefan Monnier [this message]
2017-01-11 4:38 ` bug#25105: " Tino Calancha
2017-01-11 23:27 ` Mark Oteiza
2017-01-11 23:34 ` Dmitry Gutov
2017-01-12 3:53 ` bug#25400: " Tino Calancha
2017-01-13 3:35 ` Dmitry Gutov
2017-01-13 3:55 ` Tino Calancha
2017-01-14 3:11 ` bug#25105: bug#25400: " Dmitry Gutov
2017-01-21 3:02 ` Tino Calancha
2017-01-23 3:42 ` bug#25105: " Dmitry Gutov
2017-01-13 4:25 ` Tino Calancha
2017-01-13 5:57 ` bug#25105: " npostavs
2017-01-13 6:26 ` Tino Calancha
2017-01-13 6:42 ` bug#25105: " npostavs
2017-01-13 6:54 ` Tino Calancha
2017-01-14 1:49 ` npostavs
2017-01-14 5:47 ` Tino Calancha
2017-01-16 6:26 ` Tino Calancha
2017-01-17 23:24 ` Dmitry Gutov
2017-01-18 6:11 ` Tino Calancha
2017-01-14 3:16 ` bug#25105: bug#25400: " Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv37gsyhvk.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=25400@debbugs.gnu.org \
--cc=mvoteiza@udel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).