From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: charles@aurox.ch (Charles A. Roelli)
Cc: 32460@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#32460: 27.0.50; diff-mode sometimes doesn't refine hunks
Date: Thu, 07 Mar 2019 22:07:30 -0500 [thread overview]
Message-ID: <jwv36ny5aoy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m24l8ev63w.fsf@aurox.ch> (Charles A. Roelli's message of "Thu, 07 Mar 2019 20:26:11 +0100")
> As Juri suggested, the fix for Bug#32991 probably fixed this bug.
As part of the fix for Bug#32991, I rewrote the code that visits "all"
hunks in a region, because that code had a bug which basically made it
skip every other hunk: in practice with jit-lock (where the granularity
is small enough that the region considered rarely contains more than one
hunk), it tended to "arbitrarily" miss some hunks every once in a while
(regardless of diff-hunk-next).
Not sure if this error was the cause of bug#32460 since you mention
interaction with diff-hunk-next, but I think it's indeed better to close
the bug for now and reopen it (or a new one) if it re-appears.
Stefan
prev parent reply other threads:[~2019-03-08 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 20:48 bug#32460: 27.0.50; diff-mode sometimes doesn't refine hunks Juri Linkov
2019-03-07 19:26 ` Charles A. Roelli
2019-03-08 3:07 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv36ny5aoy.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=32460@debbugs.gnu.org \
--cc=charles@aurox.ch \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).