From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#45198: 28.0.50; Sandbox mode Date: Sat, 12 Dec 2020 16:06:54 -0500 Message-ID: References: <83mtyierfs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5895"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: bzg@gnu.org, 45198@debbugs.gnu.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 12 22:35:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1koCY5-0001QK-Vg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Dec 2020 22:35:29 +0100 Original-Received: from localhost ([::1]:39084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koCY4-0006Vt-VB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Dec 2020 16:35:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koC7W-0007rD-IB for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 16:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koC7W-0001rH-8b for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 16:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koC7W-0004sr-0e for bug-gnu-emacs@gnu.org; Sat, 12 Dec 2020 16:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Dec 2020 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45198 X-GNU-PR-Package: emacs Original-Received: via spool by 45198-submit@debbugs.gnu.org id=B45198.160780722518679 (code B ref 45198); Sat, 12 Dec 2020 21:08:01 +0000 Original-Received: (at 45198) by debbugs.gnu.org; 12 Dec 2020 21:07:05 +0000 Original-Received: from localhost ([127.0.0.1]:46904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koC6a-0004rD-NE for submit@debbugs.gnu.org; Sat, 12 Dec 2020 16:07:04 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koC6Y-0004qd-FJ for 45198@debbugs.gnu.org; Sat, 12 Dec 2020 16:07:03 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D542D440F7E; Sat, 12 Dec 2020 16:06:56 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A9FE2440859; Sat, 12 Dec 2020 16:06:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1607807215; bh=Twac/IHdDuKLecpgyh+5kVryS3lVw+lulK0AT9VCukw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZVvpHT3qU906gSGAhekueYWWj+gjUZYop9eBnYOPU4YdByuoskKeK4/2Q6++2IpLW 811Q6Zaj8a0XAo78LGLptI84ACEKwko0W8G7tTZ8Agoj7c3kxkZq9aP1ohKa87Wiox ZueYwhWZU/WbqGEsMU7AwEQmUhmHN+V0sBN2KvHtH34Y5enfvNLx38tXQbTPZ7YUzk YzvzSu4FHWtVlGlKAOk4eavJoc+g+CJLzRIW+OvTSSlxPS8DS+rT5/bvMl8RuvPS00 +yoRkUa/BI8ARThfkIGMlauSwemjRlgSZVwn23Izx6OHbhXpQ3m9gDscvB1RiP0Ti4 QRrffduVOrA3w== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3058612061D; Sat, 12 Dec 2020 16:06:55 -0500 (EST) In-Reply-To: <83mtyierfs.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Dec 2020 21:48:39 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195912 Archived-At: >> static void >> redisplay_internal (void) >> { >> + /* Not sure if it's important to avoid redisplay inside a sandbox, >> + but it seems safer to avoid risking introducing security holes via >> + image libraries and such. */ >> + ensure_no_sandbox (); > > You cannot usefully call error from redisplay. Hmm... but this is at the entrance to redisplay, so I though it should still be safe at that point. If it's a problem we can replace the above with if (emacs_is_sandboxed) return; -- Stefan