From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Thu, 22 Apr 2021 14:36:49 -0400 Message-ID: References: <3ed97a9c53e0a5d4fef8@heytings.org> <87fszrz21d.fsf@mail.linkov.net> <3ed97a9c530093aca93d@heytings.org> <7dee3f4235d331cab291@heytings.org> <87r1jatd34.fsf@mail.linkov.net> <7dee3f423551aaf318cb@heytings.org> <87im4kzlfm.fsf@mail.linkov.net> <1869622e16546eafd9df@heytings.org> <871rb6np5j.fsf@mail.linkov.net> <87lf9cepqw.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32879"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dario Gjorgjevski , 45474@debbugs.gnu.org, Juri Linkov To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 22 20:37:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZeCf-0008Fc-RB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Apr 2021 20:37:30 +0200 Original-Received: from localhost ([::1]:41602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZeCe-0001Qb-TN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Apr 2021 14:37:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZeCE-0001Pp-Ow for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 14:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZeCE-0003Tv-AH for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 14:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZeCD-0000Lx-Mp for bug-gnu-emacs@gnu.org; Thu, 22 Apr 2021 14:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.16191166201350 (code B ref 45474); Thu, 22 Apr 2021 18:37:01 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 22 Apr 2021 18:37:00 +0000 Original-Received: from localhost ([127.0.0.1]:35504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZeCB-0000Lh-RL for submit@debbugs.gnu.org; Thu, 22 Apr 2021 14:37:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZeC9-0000LS-8k for 45474@debbugs.gnu.org; Thu, 22 Apr 2021 14:36:58 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9A3C9440C3A; Thu, 22 Apr 2021 14:36:51 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1FC53440F1F; Thu, 22 Apr 2021 14:36:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1619116610; bh=I1ZbABZl08sWhqaPSUC0Z0Gh8oo+DkMO3qGTm1rr8Ik=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S7IopF4mrPcIenJZsofqgh50gIT6O4R+Wh+dOTvlLH/xSp0DjBu9jEeiPCNjqnOWd XJKxwjZJb2S7dN/Igmk4i6NqNXuDdn1EZo4e4quoaNE7VJxaapt2N4RC4QaWpmr/du ICvjb8NLHLAvqo9s4GxqgHNiYUL1P4Jm/MPgEb9zqUj/K8D5fA9bhn847Czr+QQLtm ET/3KcTg37xqFXVm6FONeTeZWO6zy2L5IX8hNTdhlK5Z1eJVJRK21gBCn6sd6QaMPE RhuZKe+XI62zH1jFAiG7pEeu0f1H44aYEhuMb1i9IUWzRKU3e2GwPYqwl/1RsgIUkc ReUjSBEgYSKaw== Original-Received: from alfajor (104-222-126-84.cpe.teksavvy.com [104.222.126.84]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DE5FE12005B; Thu, 22 Apr 2021 14:36:49 -0400 (EDT) In-Reply-To: (Gregory Heytings's message of "Thu, 22 Apr 2021 15:18:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204709 Archived-At: I have the impression that I suffer from NIH syndrome with respect to your patch, so I'll refrain from commenting on it by and large, except for this part: > diff --git a/src/minibuf.c b/src/minibuf.c > index 1a637c86ad..fd780bd5c1 100644 > --- a/src/minibuf.c > +++ b/src/minibuf.c > @@ -865,6 +865,16 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, > if (STRINGP (input_method) && !NILP (Ffboundp (Qactivate_input_method))) > call1 (Qactivate_input_method, input_method); > > + if (! EQ (Vminibuffer_local_completion, Qnil)) { > + Fmake_local_variable (Qminibuffer_completion_table); > + Fset (Qminibuffer_completion_table, Vminibuffer_local_completion_table); > + Fmake_local_variable (Qminibuffer_completion_predicate); > + Fset (Qminibuffer_completion_predicate, Vminibuffer_local_completion_predicate); > + Fmake_local_variable (Qminibuffer_completion_confirm); > + Fset (Qminibuffer_completion_confirm, Vminibuffer_local_completion_confirm); > + specbind (Qminibuffer_local_completion, Qnil); > + } I really don't like adding knowledge of those variables to this function, which so far is completely oblivious to whether the minibuffer is used with completion or not. > run_hook (Qminibuffer_setup_hook); As in my patch, you could use this hook to do the completion-specific part of the setup. Stefan