From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51173: 28.0.60; gnus-article-describe-key doesn't work Date: Wed, 13 Oct 2021 16:01:51 -0400 Message-ID: References: <87h7dl6spg.fsf@gnus.org> <87r1cox4th.fsf@mail.linkov.net> <87h7dkx2g5.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29242"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Katsumi Yamaoka , 51173@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 13 22:03:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1makTO-0007GR-3C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Oct 2021 22:03:34 +0200 Original-Received: from localhost ([::1]:34154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1makTH-0001Cu-Do for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Oct 2021 16:03:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1makSt-0001Cc-4F for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2021 16:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50329) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1makSs-00041c-Rm for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2021 16:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1makSs-0003jb-ML; Wed, 13 Oct 2021 16:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 13 Oct 2021 20:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51173 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 51173-submit@debbugs.gnu.org id=B51173.163415532414193 (code B ref 51173); Wed, 13 Oct 2021 20:03:02 +0000 Original-Received: (at 51173) by debbugs.gnu.org; 13 Oct 2021 20:02:04 +0000 Original-Received: from localhost ([127.0.0.1]:33634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1makRv-0003gm-DS for submit@debbugs.gnu.org; Wed, 13 Oct 2021 16:02:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1makRs-0003fr-GT for 51173@debbugs.gnu.org; Wed, 13 Oct 2021 16:02:02 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7D68B80303; Wed, 13 Oct 2021 16:01:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 22E9A80084; Wed, 13 Oct 2021 16:01:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634155313; bh=t6yXDhzybtpvQYJsQOkiQORE2F9kUd2ySKxVjrNL9xE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S3bgyw83vwzkRJMIvgxPfWjW5fEEpCtSBML9lCWHZxwNJtaQR+JThd+Ji2aG5/ylB NQC0fvo2Zs+QH3Mpv1YyKHl/0SUK8YYspkJyLtZcU8zWQrcXSS+F/o7+YC2rjIgTaU x0erMQAV9uGLamhtA5+d6JcvQqKjZBd9CbMmVuDrHhBl9s/bSnqzCNoo41TyszwR9c nOH2xS+YuabtkweTGI2YB/XrxJVtxRDn1ZpKo6j0dmV9vGYFy9zpav7JFXepAkzhnZ hATEsUMrdMmWH0HbxaXhPlzgsVL0LKUVFWu3UROY6DOUM2tGd4BjL16BcSPi8l73rn UfudhtOJOztLw== Original-Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9BEBA1203B5; Wed, 13 Oct 2021 16:01:52 -0400 (EDT) In-Reply-To: <87h7dkx2g5.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 13 Oct 2021 20:24:42 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217173 Archived-At: >> I think this is mea culpa - commit 2d1564103e. >> It was changed to handle context menu clicks >> in the displayed window. > > This patch should handle only mouse events specially: > > diff --git a/lisp/help.el b/lisp/help.el > index fa4eaee417..956a3d0d32 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -699,7 +699,10 @@ help--analyze-key > ;; is selected from the context menu that should describe KEY > ;; at the position of mouse click that opened the context menu. > ;; When no mouse was involved, it defaults to window-point. > - (defn (save-excursion (mouse-set-point event) (key-binding key t)))) > + (defn (if (consp event) > + (save-excursion > + (mouse-set-point event) (key-binding key t)) > + (key-binding key t)))) > ;; Handle the case where we faked an entry in "Select and Paste" menu. > (when (and (eq defn nil) > (stringp (aref key (1- (length key)))) But this will still use "the wrong buffer" for mouse clicks, no? BTW, maybe a cleaner fix would be as follows: - Add a `buffer` argument to `describe-key(-briefly)`. - Pass that argument from `gnus-article-describe-key`. And to get the behavior that Juri just pushed that `buffer` argument would default to (if (consp event) (window-buffer (posn-window (event-start event))) (current-buffere)). Stefan