From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59347: 29.0.50; `:family` face setting ignored Date: Mon, 12 Dec 2022 10:30:10 -0500 Message-ID: References: <83r0xv1649.fsf@gnu.org> <0d1ea3007f532a493429@heytings.org> <83cz9f12bh.fsf@gnu.org> <835yewleyn.fsf@gnu.org> <83tu2b9rlx.fsf@gnu.org> <83k0347gtu.fsf@gnu.org> <83v8mm2ug7.fsf@gnu.org> <83cz8u2d6u.fsf@gnu.org> <831qp93nsc.fsf@gnu.org> <1a7e3acf3578520feda7@heytings.org> <87ilihjsrb.fsf@yahoo.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15058"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gregory Heytings , Eli Zaretskii , 59347@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 16:31:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4klz-0003h2-E6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 16:31:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4klk-0006po-UC; Mon, 12 Dec 2022 10:31:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4klj-0006o8-0n for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 10:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4kli-0004rk-Nn for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 10:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4kli-0008G1-7l for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 10:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59347 X-GNU-PR-Package: emacs Original-Received: via spool by 59347-submit@debbugs.gnu.org id=B59347.167085902231720 (code B ref 59347); Mon, 12 Dec 2022 15:31:02 +0000 Original-Received: (at 59347) by debbugs.gnu.org; 12 Dec 2022 15:30:22 +0000 Original-Received: from localhost ([127.0.0.1]:53633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4kl4-0008FY-Jx for submit@debbugs.gnu.org; Mon, 12 Dec 2022 10:30:22 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4kl2-0008FQ-Eu for 59347@debbugs.gnu.org; Mon, 12 Dec 2022 10:30:21 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7233A44160A; Mon, 12 Dec 2022 10:30:13 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 19F25440C66; Mon, 12 Dec 2022 10:30:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670859012; bh=zPKH8ANrS1ByGI+maIxx385uLiyLaWLpv5jMgkKCVnk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RapQ96hsBvmIyYLDxNnk9jFpn4I0kWSHi2DX+YCbsyAmQZCMx68lyOge8iow75OYe 6RQc8BXwE7RKnm54ya4UGTgsdQGFgYQxodrHBGET3+u7IvQxEdGKY5zvmU53FxcgI0 VKS7RwglfjZ5Zp+hNDGHnTkribxlbBgKkE8jSgBRiDLF0hh3NVpwOW1RB1QjbEzKmf zJNWN3eRFM9xRg3wimh8VIq6HCCjl7pxMdEV/Ik/AW8QwM0QL6MdIw4DGkxoF66orf xCxBAClmhI9G2xvvk3I9l41a3EyOQsIbKh0vlhGIPeCT4FFIoFcRvSiJD7GTiENm9Y awEkAudT4ijVg== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D393312020D; Mon, 12 Dec 2022 10:30:11 -0500 (EST) In-Reply-To: <87ilihjsrb.fsf@yahoo.com> (Po Lu's message of "Mon, 12 Dec 2022 09:49:28 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250713 Archived-At: > And what was the problem with a list? How many cycles is traversing a > list? How many time will it take for your CPU to perform everything? > Premature optimization is the root of all evil. It was not premature optimization. It was the simpler way to write the code. Your patch made the C code more complex (not just slower) for the benefit of a cleaner ELisp-level interface. A better way to get that same result would be to write an ELisp function on top of Gregory's bitmask variable. This way, you'd get a clean&simple&efficient C code still with a convenient ELisp API. Any chance someone could do that so we can move on? Stefan