From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms Date: Wed, 05 Jul 2023 08:43:15 -0400 Message-ID: References: <83ilayk2yz.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35112"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philipp Stephani , 64459@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 05 14:44:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qH1rn-0008pY-FE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jul 2023 14:44:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qH1rd-0001jB-2j; Wed, 05 Jul 2023 08:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH1rZ-0001i8-Qy for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 08:44:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qH1rV-0005pZ-Ui for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qH1rV-0005JR-QW for bug-gnu-emacs@gnu.org; Wed, 05 Jul 2023 08:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jul 2023 12:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64459 X-GNU-PR-Package: emacs Original-Received: via spool by 64459-submit@debbugs.gnu.org id=B64459.168856101120377 (code B ref 64459); Wed, 05 Jul 2023 12:44:01 +0000 Original-Received: (at 64459) by debbugs.gnu.org; 5 Jul 2023 12:43:31 +0000 Original-Received: from localhost ([127.0.0.1]:37887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH1r1-0005Ia-I8 for submit@debbugs.gnu.org; Wed, 05 Jul 2023 08:43:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH1qy-0005IN-Ag for 64459@debbugs.gnu.org; Wed, 05 Jul 2023 08:43:29 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 164781000DC; Wed, 5 Jul 2023 08:43:23 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A777510002F; Wed, 5 Jul 2023 08:43:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688560997; bh=fLGEL6beT29nwhy1Elch1moE2uaJcze6X8EakcRxYyM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X3sdaj2n4J1GfMdtijvZk7hEyzMm98LkqAzcTaRQEW434US00lRqofrKWSMzvwbHj fD52+iMwxbqFsrCLQlcgv6jeT0m+F4vcVslk7CSOF8v0l7jPGt43rcZ8lg4ZWryt/r t4IAt2O/yBK0zKK5EzXIlQ87UZYZ/v7robF9lkEP5jmTsE+glQoCH4IShE3x2aVkNC qZGcr0jyS3hZ9LTT9ncr6sWaAiP12MWTID626T3tpcu6QO7FCGUKM9+n7fwaPO2dgG Jan0sjl1u7YhR+uA0ywInd7pqPmZ5UJ3eMDl1QXbqOgVfIKV1t6lf+3V1N+rL84oMd GHyUR6t2155gg== Original-Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7EA9D1204C0; Wed, 5 Jul 2023 08:43:17 -0400 (EDT) In-Reply-To: <83ilayk2yz.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Jul 2023 14:33:08 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264630 Archived-At: >> > > diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el >> > > index d610fa005cc..002a24af18b 100644 >> > > --- a/lisp/emacs-lisp/syntax.el >> > > +++ b/lisp/emacs-lisp/syntax.el >> > > @@ -249,11 +249,12 @@ syntax-propertize-rules >> > > Note: There may be at most nine back-references in the REGEXPs of >> > > all RULES in total." >> > > (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. >> > > - (form &rest >> > > - (numberp >> > > - [&or stringp ;FIXME: Use &wrap >> > > - ("prog1" [&or stringp def-form] def-body) >> > > - def-form]))))) >> > > + (def-form >> > > + &rest >> > > + (numberp >> > > + [&or stringp ;FIXME: Use &wrap >> > > + ("prog1" [&or stringp form] def-body) >> > > + form]))))) >> > > (let ((newrules nil)) >> > > (while rules >> > > (if (symbolp (car rules)) >> > >> > No, this one introduces a regression. Try that one: >> > >> >> Yeah, that works at least in the cases I've tested. Thanks! > > Stefan, this is for master, right? Yes: if you want it for `emacs-29`, I do think it's perfectly safe (it just replaces the one `form` with `def-form`), but I don't see any urgency here. Stefan