From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Mon, 17 Jul 2023 08:53:00 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <87ttu4gnpt.fsf@localhost> <83351o9m6h.fsf@gnu.org> <87ilakgmjo.fsf@localhost> <83pm4r9apt.fsf@gnu.org> <83mszv93yb.fsf@gnu.org> <83edl78yly.fsf@gnu.org> <838rbe944b.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3866"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 14:57:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLNn4-0000hK-VR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 14:57:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLNk3-00074r-DI; Mon, 17 Jul 2023 08:54:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLNjn-0006eQ-L5 for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 08:54:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLNjm-0001Nc-B9 for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 08:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLNjl-0004VD-Kx for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 08:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2023 12:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168959839117251 (code B ref 64596); Mon, 17 Jul 2023 12:54:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 17 Jul 2023 12:53:11 +0000 Original-Received: from localhost ([127.0.0.1]:49371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLNiw-0004UA-LJ for submit@debbugs.gnu.org; Mon, 17 Jul 2023 08:53:10 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLNiu-0004Ty-Gs for 64596@debbugs.gnu.org; Mon, 17 Jul 2023 08:53:09 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2C1B644062D; Mon, 17 Jul 2023 08:53:03 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C71574404EC; Mon, 17 Jul 2023 08:53:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689598381; bh=+pfN9t/8nASzZ7dM/FbIzeMzyhaBFhuU8pFAKC2MuTw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Lr53vlE1nfcKFvoJQ2HS+8EbSr57B4i9Jkgpoesb9WSbqynCX48jwzmaxZWc9qGYY 6rUDg4gv7QSdQKyU70CwAoBry3zGNSf0VFl+EHg0+BjQ/a82lLVlWH1RlsQGfpV6Co YljRvqx3AXWHJH+8k5v6F4vtKJXlYCkelYrxb1UXzjPrWe4/W0Q9OBOQa8/lDhhJLv L0H98c3vFlitS6D+EQ+6SDVDLAqzBMNsqnGmEX3YTuZqXxu/zYHqeFTJ7084SqxDw1 wHyZmjyaH/l4NHG3CT27FVaaE73A9rPVvsX2mjLr23e1yFWQjxPi3vdSQXzGnMprxw SUEXTDMKUZ6ig== Original-Received: from pastel (unknown [108.175.226.218]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A03C0120099; Mon, 17 Jul 2023 08:53:01 -0400 (EDT) In-Reply-To: <838rbe944b.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 Jul 2023 14:20:04 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265393 Archived-At: >> > That's not all of the uses of this flag. Here's one example of other >> > uses: >> > >> > if (some_windows >> > && !f->redisplay >> > && !w->redisplay >> > && !XBUFFER (w->contents)->text->redisplay) >> > continue; >> > >> > (This avoids updating the tool bar and the tab bar of the frame, and >> > there's a similar condition that avoids updating the frame's title.) >> Right, but notice that what we're fundamentally checking is whether `w` >> (which is the frame's selected window here) needs to be updated, because >> that's the one currently "occupying" the tool-bar. > But testing the frame's redisplay flag will produce false positives, > because many changes that require to redraw the frame's windows don't > affect the tool bar or the frame's title. Of course, we have loads of false positives. The point of the `redisplay` flags is just to rule out things we can easily rule out. It's very coarse. It could be made finer, of course. > No, my point is that fset_redisplay shouldn't set > windows_or_buffers_changed. Setting `windows_or_buffers_changed` there is currently necessary in order to make sure we look at the `redisplay` bits (as opposed to updating only the selected window). Stefan