From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65726: 29.1.50; Crash in regexp engine Date: Thu, 21 Sep 2023 14:08:58 -0400 Message-ID: References: <8e1b4e50-0430-3eb3-e486-60def1e4821f@gmx.at> <83fs3u5e7u.fsf@gnu.org> <835y4q5apw.fsf@gnu.org> <776370AB-662F-4C0A-95BF-97DEA4F18F54@gmail.com> <3A0AC9E2-A420-47B6-870A-69C53FCAEF71@gmail.com> <65105BCA-1884-4673-A8F8-03E3C7ABAAEA@gmail.com> <5882311F-DEAE-4220-B241-86367BF07E78@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: martin rudalics , Eli Zaretskii , 65726-done@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 21 20:10:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjO7z-0002LD-4R for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Sep 2023 20:10:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjO7d-0003PG-HF; Thu, 21 Sep 2023 14:09:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjO7c-0003Oa-7M for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 14:09:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjO7b-0005tc-Ur for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 14:09:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjO7l-0004eS-OP for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 14:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Sep 2023 18:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65726 X-GNU-PR-Package: emacs Original-Received: via spool by 65726-done@debbugs.gnu.org id=D65726.169531976017826 (code D ref 65726); Thu, 21 Sep 2023 18:10:01 +0000 Original-Received: (at 65726-done) by debbugs.gnu.org; 21 Sep 2023 18:09:20 +0000 Original-Received: from localhost ([127.0.0.1]:34788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjO76-0004dS-9h for submit@debbugs.gnu.org; Thu, 21 Sep 2023 14:09:20 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjO72-0004dA-DS for 65726-done@debbugs.gnu.org; Thu, 21 Sep 2023 14:09:18 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E5686442AFF; Thu, 21 Sep 2023 14:09:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1695319739; bh=R6Wt3KiQScsDF4ohv4YJSC9xQo6Re0R6t8ktbrmKgfY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fwipxrEgX38g6rRtztCclA4KLEIwJ/+7FCxe7o5FDyeqZS1hGY5YjYVIMCXuOfwWO yiT+pgKEFPvFLENcRZHR6nlD/uYnkiav/byqM1upZjuvGIRS9LLEwA9r0oKCdopCqQ M27H4T9vasp/luRpjtY2s/68NN0dfn6tVNYAMDnAegix4LjpRykx2g+5OCG+/pQojP 8X9eb656Pf5ibA2LGMazVot+EFVqgH/emmcc/8Ztd0Y6urio7+0XLIgvButelN9s5Z zsIvh+DJ/xbhwXav58KnK87Xf2RaDl7Rz9wSM40emEAdhox1kjBFW7/6mr/2on1oJb eQaotaK0MyHqQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7E131442AFC; Thu, 21 Sep 2023 14:08:59 -0400 (EDT) Original-Received: from pastel (unknown [45.72.220.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 55CC0120218; Thu, 21 Sep 2023 14:08:59 -0400 (EDT) In-Reply-To: <5882311F-DEAE-4220-B241-86367BF07E78@gmail.com> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Thu, 21 Sep 2023 19:23:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271014 Archived-At: > So this is what prevented me from running with counts above 2**15 and > debugging enabled for all these years... Looks like it. In any case, I pushed a variant of the last patch to `master` and I think the case is now closed. We may want to revisit it, presumably by really keeping track of the all visited nodes, but this seems to work well for now and I'm confident that it is safe (regardless of the shape of the bytecode, it should always terminate and it should never apply the optimization if it's incorrect, and with the shape of the bytecode we currently produce it does correctly apply the optimization in the cases I checked). Stefan