From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67161: 30.0.50; [PATCH] Add option `dired-filename-display-length' Date: Mon, 20 Nov 2023 13:55:58 -0500 Message-ID: References: <8334x8tqi9.fsf@gnu.org> <83a5rfrych.fsf@gnu.org> <83sf55q4nc.fsf@gnu.org> <83jzqfmiuj.fsf@gnu.org> <835y1wk4ls.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5360"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Liu Hui , 67161@debbugs.gnu.org, stefankangas@gmail.com, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 20 19:59:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r59UP-0001EM-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Nov 2023 19:59:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r59U5-0004rB-U3; Mon, 20 Nov 2023 13:59:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r59U5-0004r1-5k for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 13:59:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r59U4-0004Ol-U4 for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 13:59:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r59U6-0003PQ-Ge for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 13:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Nov 2023 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67161 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67161-submit@debbugs.gnu.org id=B67161.170050672513050 (code B ref 67161); Mon, 20 Nov 2023 18:59:02 +0000 Original-Received: (at 67161) by debbugs.gnu.org; 20 Nov 2023 18:58:45 +0000 Original-Received: from localhost ([127.0.0.1]:54565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r59To-0003OQ-OK for submit@debbugs.gnu.org; Mon, 20 Nov 2023 13:58:45 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r59Tl-0003Nr-UB for 67161@debbugs.gnu.org; Mon, 20 Nov 2023 13:58:42 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5A8C3100068; Mon, 20 Nov 2023 13:58:34 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700506713; bh=MrxR6apfXC/ncSfKiyO8oBYmmnWgff14wNNfaPPBwOA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RVCc3sM7mrzNUFzb4pbVZxFFww7AtgZBQXvY8WP5M0obSoIle8rXzTVYj2rjJobuJ 04xgPTaHZKqwZkFRPHjEmj0r1D5V61X56whNV3G7xbZe3SzGuMujTtN48XoT+K32v8 0nCI+5hVYJ+AImRNtbE3ztM3ZwyiGjML2TJmaKoFUdIEvEWnoZhkuibxylk62IhCCV bTjeJbY9GQYxkio7aK7+Om6s01tpZAsFRPWMEt78EJBggAAteCGcpVd6abs/NM0D0q p1iUNc9xl/OHxHvRPVefSN8GDhyIutvQGbto9ZNchbx/rpW+uFk11PDggpbylsPmXB u5AamQJzzbMhw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B0989100033; Mon, 20 Nov 2023 13:58:33 -0500 (EST) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9B20A1202E0; Mon, 20 Nov 2023 13:58:33 -0500 (EST) In-Reply-To: <835y1wk4ls.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Nov 2023 14:10:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274684 Archived-At: >> in the attached patch, then text in hidden part can be matched >> regardless of search-invisible being open or t. It also has a bonus >> that hidden text can be revealed during isearch. Yes, using an overlay sounds like a better choice here, thanks. > Juri, this seems to be a usability bug? Why does Isearch only look > into invisible overlay properties, but not text properties? IOW, why > doesn't "M-s i" set the value of isearch-invisible to t, not 'open'? I think the idea is that matching invisible text is somewhat inconvenient, so it's better to temporarily reveal/open that text. But I think it points to an bug in Isearch: when `isearch-invisible` is `open` we should match text inside invisible text, regardless if we can reveal/open that invisible text or not. IOW `open` should find the same matches as `t`, the only difference being that it additionally (tries to) reveal/open the text. > In any case, the differences between properties and > overlays is unusual and IMO a misfeature. Can this be fixed? Indeed, it would be good to implement some way to reveal/open invisible text made invisible via text-properties rather than overlays. That also applies to `reveal-mode`, of course. Stefan