From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70966: 30.0.50; eshell/diff produces track-changes errors Date: Thu, 16 May 2024 11:58:31 -0400 Message-ID: References: <87jzjv7xyp.fsf@stebalien.com> <86le4bj5bd.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6642"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Steven Allen , 70966@debbugs.gnu.org To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 16 17:59:40 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7dW8-0001bA-HY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 May 2024 17:59:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7dVZ-0001pB-IV; Thu, 16 May 2024 11:59:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7dVV-0001lR-Q7 for bug-gnu-emacs@gnu.org; Thu, 16 May 2024 11:59:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7dVU-0004or-9k for bug-gnu-emacs@gnu.org; Thu, 16 May 2024 11:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7dVW-0008W2-HC for bug-gnu-emacs@gnu.org; Thu, 16 May 2024 11:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2024 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70966 X-GNU-PR-Package: emacs Original-Received: via spool by 70966-submit@debbugs.gnu.org id=B70966.171587512232724 (code B ref 70966); Thu, 16 May 2024 15:59:02 +0000 Original-Received: (at 70966) by debbugs.gnu.org; 16 May 2024 15:58:42 +0000 Original-Received: from localhost ([127.0.0.1]:49489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dVC-0008Vk-B3 for submit@debbugs.gnu.org; Thu, 16 May 2024 11:58:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7dVB-0008VY-5d for 70966@debbugs.gnu.org; Thu, 16 May 2024 11:58:41 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 52EFA100061; Thu, 16 May 2024 11:58:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1715875112; bh=n1L0/zrJl0ZaKmI3h503eVTAkSd2PIvnjUHOfhmorAw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=c9xshN14chEgzdoXtzqmWTM45fjRaXCv/XCFgwloMt7NrJZNn3m/ZdlP/fx7HLY+l Ty23uBM4xADuwg7iGqGbBi18ztPTUWQxFS6XQDT9pdQzSAl5TSeqm4EMdeU4f/gB9v aOWC76aEiaHWb41LZUJDEba3ze1YzpC6pDGXWX+Y3grAPcdap0ozQ5gZm8SnAo+tP0 8ZoZ4o41d+wXhtLFWOPX3bbsTStVuwR4xJQ0y658SD3mmUEEVLBrsij8ac0+r6N/iD e5HPBpUtzB8WH59uMb0M0yp+glPdX4jwrSmvwmeeyk4qITcaDph7DYDU62kKQ7pAx/ 2tdUxHYrAEIjQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6CF40100035; Thu, 16 May 2024 11:58:32 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 59DBA12045A; Thu, 16 May 2024 11:58:32 -0400 (EDT) In-Reply-To: <86le4bj5bd.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 May 2024 21:30:46 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285165 Archived-At: --=-=-= Content-Type: text/plain The patch below seems to fix this problem. John, do you remember why you had those let-bindings (which originally were let-binding `after-change-functions` to nil)? Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=eshell.patch diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el index 78a448a41a5..8e993d47183 100644 --- a/lisp/eshell/esh-mode.el +++ b/lisp/eshell/esh-mode.el @@ -623,7 +623,8 @@ eshell-send-input ;; Note that the input string does not include its terminal newline. (let* ((proc-running-p (eshell-head-process)) (send-to-process-p (and proc-running-p (not queue-p))) - (inhibit-modification-hooks t)) + ;; (inhibit-modification-hooks t) + ) (unless (and send-to-process-p (not (eq (process-status (eshell-head-process)) @@ -710,7 +711,8 @@ eshell-interactive-filter (unless buffer (setq buffer (current-buffer))) (when (and string (buffer-live-p buffer)) - (let ((inhibit-modification-hooks t)) + (let (;; (inhibit-modification-hooks t) + ) (with-current-buffer buffer (let ((functions eshell-preoutput-filter-functions)) (while (and functions string) --=-=-=--