From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: John Wiegley <johnw@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, Steven Allen <steven@stebalien.com>,
70966@debbugs.gnu.org
Subject: bug#70966: 30.0.50; eshell/diff produces track-changes errors
Date: Thu, 16 May 2024 11:58:31 -0400 [thread overview]
Message-ID: <jwv34qhda57.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86le4bj5bd.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 May 2024 21:30:46 +0300")
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
The patch below seems to fix this problem.
John, do you remember why you had those let-bindings (which originally
were let-binding `after-change-functions` to nil)?
Stefan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: eshell.patch --]
[-- Type: text/x-diff, Size: 963 bytes --]
diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
index 78a448a41a5..8e993d47183 100644
--- a/lisp/eshell/esh-mode.el
+++ b/lisp/eshell/esh-mode.el
@@ -623,7 +623,8 @@ eshell-send-input
;; Note that the input string does not include its terminal newline.
(let* ((proc-running-p (eshell-head-process))
(send-to-process-p (and proc-running-p (not queue-p)))
- (inhibit-modification-hooks t))
+ ;; (inhibit-modification-hooks t)
+ )
(unless (and send-to-process-p
(not (eq (process-status
(eshell-head-process))
@@ -710,7 +711,8 @@ eshell-interactive-filter
(unless buffer
(setq buffer (current-buffer)))
(when (and string (buffer-live-p buffer))
- (let ((inhibit-modification-hooks t))
+ (let (;; (inhibit-modification-hooks t)
+ )
(with-current-buffer buffer
(let ((functions eshell-preoutput-filter-functions))
(while (and functions string)
next prev parent reply other threads:[~2024-05-16 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 18:05 bug#70966: 30.0.50; eshell/diff produces track-changes errors Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-15 18:30 ` Eli Zaretskii
2024-05-16 15:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-16 16:15 ` John Wiegley
2024-05-25 7:55 ` Eli Zaretskii
2024-05-26 6:25 ` John Wiegley
2024-05-26 8:16 ` Eli Zaretskii
2024-05-28 21:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-28 23:48 ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv34qhda57.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=70966@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=johnw@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).