From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Daniel Clemente <n142857@gmail.com>
Cc: 71223@debbugs.gnu.org
Subject: bug#71223: 30.0.50; stack overflow after very fast opening and closing of frames
Date: Tue, 28 May 2024 20:28:37 -0400 [thread overview]
Message-ID: <jwv34q131k4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAJKAhPBwZPkLw=uevo5_WduWQPZdY+wrAuQBXeStd32UqTCyTg@mail.gmail.com> (Daniel Clemente's message of "Mon, 27 May 2024 11:01:15 +0000")
[-- Attachment #1: Type: text/plain, Size: 143 bytes --]
Hi Daniel,
Could you try the patch below which sequentializes the processing of the
process-filters to avoid such recursion?
Stefan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: server.patch --]
[-- Type: text/x-diff, Size: 3347 bytes --]
diff --git a/lisp/server.el b/lisp/server.el
index b65053267a6..7d8b8d37fad 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -1046,6 +1046,8 @@ server-execute-continuation
(process-put proc 'continuation nil)
(if continuation (ignore-errors (funcall continuation)))))
+(defvar server--pending-filter-calls t)
+
(cl-defun server-process-filter (proc string)
"Process a request from the server to edit some files.
PROC is the server process. STRING consists of a sequence of
@@ -1145,6 +1147,18 @@ server-process-filter
`-suspend'
Suspend this terminal, i.e., stop the client process.
Sent when the user presses \\[suspend-frame]."
+ (if (listp server--pending-filter-calls)
+ ;; We're already running another instance of this process filter.
+ ;; Let's make sure we don't run them in a nested fashion.
+ (push (cons proc string) server--pending-filter-calls)
+ (let ((server--pending-filter-calls nil))
+ (push (cons proc string) server--pending-filter-calls)
+ (while server--pending-filter-calls
+ (dolist (pending-call (prog1 (nreverse server--pending-filter-calls)
+ (setq server--pending-filter-calls nil)))
+ (server--process-filter (car pending-call) (cdr pending-call)))))))
+
+(cl-defun server--process-filter (proc string)
(server-log (concat "Received " string) proc)
;; First things first: let's check the authentication
(unless (process-get proc :authenticated)
@@ -1159,6 +1173,9 @@ server-process-filter
;; it, in case the error written by emacsclient to stderr is not
;; visible for some reason.
(message "Authentication failed")
+ ;; FIXME: Ideally we should not need `sit-for' here and instead use
+ ;; some `message-timed' call which makes sure the message is visible
+ ;; without forcing us to wait here.
(sit-for 2)
(server-send-string
proc (concat "-error " (server-quote-arg "Authentication failed")))
@@ -1169,10 +1186,9 @@ server-process-filter
(delete-terminal terminal))))
;; Before calling `delete-process', give emacsclient time to
;; receive the error string and shut down on its own.
- (sit-for 1)
- (delete-process proc)
+ (run-with-timer 1 nil #'delete-process proc)
;; We return immediately.
- (cl-return-from server-process-filter)))
+ (cl-return-from server--process-filter)))
(let ((prev (process-get proc 'previous-string)))
(when prev
(setq string (concat prev string))
@@ -1508,6 +1524,9 @@ server-return-error
;; it, in case the error written by emacsclient to stderr is not
;; visible for some reason.
(message (error-message-string err))
+ ;; FIXME: Ideally we should not need `sit-for' here and instead use
+ ;; some `message-timed' call which makes sure the message is visible
+ ;; without forcing us to wait here.
(sit-for 2)
(server-send-string
proc (concat "-error " (server-quote-arg
@@ -1520,7 +1539,7 @@ server-return-error
(delete-terminal terminal))))
;; Before calling `delete-process', give emacsclient time to
;; receive the error string and shut down on its own.
- (sit-for 5)
+ (run-with-timer 5 nil #'delete-process proc)
(delete-process proc)))
(defun server-goto-line-column (line-col)
next prev parent reply other threads:[~2024-05-29 0:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 11:01 bug#71223: 30.0.50; stack overflow after very fast opening and closing of frames Daniel Clemente
2024-05-27 12:23 ` Eli Zaretskii
2024-05-27 12:36 ` Eli Zaretskii
2024-05-27 14:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-27 15:21 ` Eli Zaretskii
2024-05-27 17:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-27 18:15 ` Eli Zaretskii
2024-05-27 18:33 ` Eli Zaretskii
2024-05-29 0:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 11:48 ` Eli Zaretskii
2024-05-29 20:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 5:12 ` Eli Zaretskii
2024-05-30 13:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 15:29 ` Eli Zaretskii
2024-05-27 15:21 ` Daniel Clemente
2024-05-27 15:26 ` Eli Zaretskii
2024-05-29 0:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-29 10:54 ` Daniel Clemente
2024-05-29 19:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 4:56 ` Eli Zaretskii
2024-05-30 13:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 21:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 5:19 ` Eli Zaretskii
2024-05-30 16:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 16:49 ` Eli Zaretskii
2024-05-30 18:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 22:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 5:45 ` Eli Zaretskii
2024-05-31 12:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 11:22 ` Daniel Clemente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv34q131k4.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=71223@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=n142857@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).