From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73431: Add `setf` support for `stream.el` in ELPA Date: Sun, 27 Oct 2024 10:26:28 -0400 Message-ID: References: <827cc7fc-10be-4b93-bd67-f275193e5d84@protonmail.com> <932d7782-5685-4a43-b34c-fc0bb3a958e4@protonmail.com> <87zfnk6ydj.fsf@posteo.net> <9db72ab8-604e-451d-b9a0-74fa5b3fa81f@protonmail.com> <87a5fic3om.fsf@posteo.net> <7de379ab-a4f2-4853-96dc-cdf05dd7218e@protonmail.com> <09504d12-9ca6-4b4d-84ff-c7f9d1087192@protonmail.com> <87o73dmp7q.fsf@web.de> <87ed48mgbu.fsf@web.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4546"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , philipk@posteo.net, nicolas@petton.fr, 73431@debbugs.gnu.org To: Okamsn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 27 15:27:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t54F8-0000x0-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Oct 2024 15:27:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t54Es-00068r-Vl; Sun, 27 Oct 2024 10:27:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t54Eq-00068X-Q3 for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 10:27:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t54Eq-0004If-Gg for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 10:27:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Ib+lKVYMfqJ14e0uv4oLltLx4rhKwtjVh0jliN9NJqs=; b=M/fVya86GcGlExerb2huIjUjvVvYGanWVKuAyP3p+kcPyxLamPYj0bN2MF087ZRtADJ0ru/F/EL8UsmV2MAEbz0pAYLASbJnY1JYAqMleyp9H5LyBIedMv8Zva4LNkrtFEsAKc3b5ps8hwdpS0sa9H8kmW+F8uw2jl1b3ZikPA/SR5bozCTuIoAXvdW22ulEebz2GT8FqZBJPtgAPWYrai54RVdcAC6apxGg4K3pjllLsB244dqBcM+z0ZElv4oigKM4YQ0aAtgseZlcjPoN7RwhnxgrZ88D3bYQBaFJ9pGx3IVzoQVE80LaikbolofzDene4uQZRzcVgCDclTVtew==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t54FO-00018w-8M for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 10:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Oct 2024 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73431 X-GNU-PR-Package: emacs Original-Received: via spool by 73431-submit@debbugs.gnu.org id=B73431.17300392354315 (code B ref 73431); Sun, 27 Oct 2024 14:28:02 +0000 Original-Received: (at 73431) by debbugs.gnu.org; 27 Oct 2024 14:27:15 +0000 Original-Received: from localhost ([127.0.0.1]:45865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t54Ed-00017X-1R for submit@debbugs.gnu.org; Sun, 27 Oct 2024 10:27:15 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t54Eb-00017I-9w for 73431@debbugs.gnu.org; Sun, 27 Oct 2024 10:27:14 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 640814410BE; Sun, 27 Oct 2024 10:26:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1730039190; bh=Z/nCv4xCHOu4ahysETast2AOtI/VzM5j/NQ7UkY0JDA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gTD6iGU7zRYq34zWrlkBYpewXzNr//sy0TKSxg14UTq1RNW0H7SjGzFOPrRfs+0YK TmEsK8I0XXYMOWLBJpISlTZNqHlk7yYgddNwkSLxxEvdXuo1BemWz7PO9ZTanN2XEn VPLI+NxIoKd2Jku2hANVBsuv12bYICu9djzCixXjEWpM8xrp9sKxqoDao366twsbtG ONQDZ1mYwFyTwxDxekK28xkN/bMABs9aOuq5PChCS0M+KWN7iSHhcwwMMw4Bj8zpiH 7mMZOYeKhm2sfq1L3B7b/4PO5jQc6dnEJPQTE+L7WMqjpgSn84rUuPn3VMMBtJd3+e 5wAuQHDMCp/yg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3EE5A440408; Sun, 27 Oct 2024 10:26:30 -0400 (EDT) Original-Received: from pastel (69-196-161-60.dsl.teksavvy.com [69.196.161.60]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F16E51201CF; Sun, 27 Oct 2024 10:26:29 -0400 (EDT) In-Reply-To: (okamsn@protonmail.com's message of "Thu, 24 Oct 2024 02:51:05 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294363 Archived-At: >> | stream.el:395:15: Warning: docstring wider than 80 characters >> | stream.el:421:15: Warning: docstring has wrong usage of unescaped single >> | quotes (use \=' or different quoting such as `...') >> >> Could you please try to care about these? > > For shortening the first line of the documentation of `seq-take-while`, > do you think changing "Return a stream of the successive elements for > which (PRED elt) is non-nil in STREAM" to "Return a stream of serial > elements in STREAM for which PRED returns non-nil" works? Why do we even need a docstring? The generic function already comes with its docstring: Take the successive elements of SEQUENCE for which PRED returns non-nil. PRED is a function of one argument. The function keeps collecting elements from SEQUENCE and adding them to the result until PRED returns nil for an element. Value is a sequence of the same type as SEQUENCE. Methods of a generic function shouldn't duplicate the generic function's docstring. They may add some clarifications specific to the method, of course, but in most cases no docstring is needed. Look at what your docstring does in `C-h f seq-take-while` to judge whether it's appropriate. Stefan