unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: 6100@debbugs.gnu.org
Subject: bug#6100: c-beginning-of-defun doesn't push mark
Date: Tue, 11 May 2010 15:22:10 -0400	[thread overview]
Message-ID: <jwv1vdi2qmz.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20100506105433.GA1366@muc.de> (Alan Mackenzie's message of "Thu,  6 May 2010 10:54:33 +0000")

> The speed of c-{beginning,end}-of-defun have presented problems from time
> to time.  Quadrupling CC Mode's end-of-defun's runtime doesn't seem a
> good idea.  I want to keep the handling of c-{beginning,end}-of-defun
> symmetrical for ease of maintenance.

IIUC the speed of those operations has been a problem when called many
times within a single command (i.e. the cumulative time became
a problem), so it shouldn't be a problem for interactive use where doing
it 4 times rather than 1 shouldn't be noticeable.

IOW, the problem was algorithmic, but running the same code 4 times
makes no difference algorithmically.

> I would favour your patch to these defuns which pushes the marks.

It's your code, so it's your choice.


        Stefan





  parent reply	other threads:[~2010-05-11 19:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 16:01 bug#6100: c-beginning-of-defun doesn't push mark Juri Linkov
2010-05-05 13:16 ` Stefan Monnier
     [not found] ` <jwvk4ripk1d.fsf-monnier+emacs@gnu.org>
2010-05-05 18:28   ` Juri Linkov
2010-05-05 20:29     ` Stefan Monnier
2010-05-06 10:54     ` Alan Mackenzie
     [not found]     ` <20100506105433.GA1366@muc.de>
2010-05-11 19:22       ` Stefan Monnier [this message]
2010-05-12 11:21         ` Alan Mackenzie
2010-05-12 13:26 ` bug#6100: Fix Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1vdi2qmz.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=6100@debbugs.gnu.org \
    --cc=acm@muc.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).