From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts) Date: Fri, 20 Aug 2010 23:58:21 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1282343970 16089 80.91.229.12 (20 Aug 2010 22:39:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 20 Aug 2010 22:39:30 +0000 (UTC) Cc: Damyan Pepper , 6303@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 21 00:39:27 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OmaFB-00066n-1P for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Aug 2010 00:39:25 +0200 Original-Received: from localhost ([127.0.0.1]:39785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OmZm0-0008GW-2z for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Aug 2010 18:09:16 -0400 Original-Received: from [140.186.70.92] (port=50960 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OmZls-0008Ex-4m for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2010 18:09:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OmZlq-0007xu-51 for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2010 18:09:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54766) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmZlq-0007xq-2S for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2010 18:09:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OmZb7-00075J-OH; Fri, 20 Aug 2010 17:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Aug 2010 21:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6303 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: patch Original-Received: via spool by 6303-submit@debbugs.gnu.org id=B6303.128234144527222 (code B ref 6303); Fri, 20 Aug 2010 21:58:01 +0000 Original-Received: (at 6303) by debbugs.gnu.org; 20 Aug 2010 21:57:25 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmZaP-000751-FC for submit@debbugs.gnu.org; Fri, 20 Aug 2010 17:57:25 -0400 Original-Received: from impaqm2.telefonica.net ([213.4.138.2]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmZaN-00074v-3Z for 6303@debbugs.gnu.org; Fri, 20 Aug 2010 17:57:16 -0400 Original-Received: from IMPmailhost6.adm.correo ([10.20.102.127]) by IMPaqm2.telefonica.net with bizsmtp id wlfD1e00F2kvMAa3MlyQ4S; Fri, 20 Aug 2010 23:58:24 +0200 Original-Received: from ceviche.home ([83.61.35.93]) by IMPmailhost6.adm.correo with BIZ IMP id wlyM1e00D20aCvn1mlyNP9; Fri, 20 Aug 2010 23:58:24 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="monnier$movistar.es" |auth_email="monnier@movistar.es" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" Original-Received: by ceviche.home (Postfix, from userid 20848) id C3D67660E9; Fri, 20 Aug 2010 23:58:21 +0200 (CEST) In-Reply-To: (Juanma Barranquero's message of "Tue, 29 Jun 2010 11:03:33 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 20 Aug 2010 17:58:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39678 Archived-At: > Another thing. This bit: > char *str = SYMBOLP (val) ? SDATA (SYMBOL_NAME (val)) : NULL; > if (INTEGERP (val)) str = XINT (val) != 0 ? "true" : "false"; > if (str == NULL) str = "true"; > would perhaps be clearer as > char *str; > if (INTEGERP (val)) > str = XINT (val) ? "true" : "false"; > else if (SYMBOLP (val)) > str = SDATA (SYMBOL_NAME (val)); > else > str = "true"; Actually, I'd write it: char *str = (INTEGERP (val) ? (XINT (val) ? "true" : "false") : SYMBOLP (val) ? SDATA (SYMBOL_NAME (val)) : "true") -- Stefan "look'ma! no assignment!"