From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6076: 23.1.96; [PATCH] rcirc-complete for nicks and commands Date: Sat, 04 Sep 2010 10:24:35 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1283589614 22652 80.91.229.12 (4 Sep 2010 08:40:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 4 Sep 2010 08:40:14 +0000 (UTC) Cc: 6076@debbugs.gnu.org, Leo To: Ryan Yeske Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 04 10:40:13 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OroIF-0000BB-7w for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Sep 2010 10:40:11 +0200 Original-Received: from localhost ([127.0.0.1]:59135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OroIE-0002OW-9I for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Sep 2010 04:40:10 -0400 Original-Received: from [140.186.70.92] (port=42784 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OroI1-0002NY-OC for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2010 04:39:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OroI0-0004Vq-1b for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2010 04:39:57 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44633) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OroI0-0004Vm-0E for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2010 04:39:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Oro2c-0005ua-Be; Sat, 04 Sep 2010 04:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Sep 2010 08:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6076 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6076-submit@debbugs.gnu.org id=B6076.128358859422712 (code B ref 6076); Sat, 04 Sep 2010 08:24:02 +0000 Original-Received: (at 6076) by debbugs.gnu.org; 4 Sep 2010 08:23:14 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oro1q-0005uH-Kb for submit@debbugs.gnu.org; Sat, 04 Sep 2010 04:23:14 -0400 Original-Received: from impaqm3.telefonica.net ([213.4.138.3]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oro1o-0005uB-FG for 6076@debbugs.gnu.org; Sat, 04 Sep 2010 04:23:13 -0400 Original-Received: from IMPmailhost4.adm.correo ([10.20.102.125]) by IMPaqm3.telefonica.net with bizsmtp id 2YF31f00A2iL0W23PYQdSb; Sat, 04 Sep 2010 10:24:37 +0200 Original-Received: from ceviche.home ([83.61.33.16]) by IMPmailhost4.adm.correo with BIZ IMP id 2YQb1f0040LsqWj1kYQcSe; Sat, 04 Sep 2010 10:24:37 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="monnier$movistar.es" |auth_email="monnier@movistar.es" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" Original-Received: by ceviche.home (Postfix, from userid 20848) id D4814661B8; Sat, 4 Sep 2010 10:24:35 +0200 (CEST) In-Reply-To: (Ryan Yeske's message of "Fri, 03 Sep 2010 15:13:13 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 04 Sep 2010 04:24:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39950 Archived-At: > I reviewed Leo's updated patch at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6076#47 > I agree with Leo, we should install this patch and then look into > improvements using completion in region. I mostly agree, but I think the patch should first be restructured into one or 2 functions suitable for completion-at-point-functions (i.e. either one that provides the completion data for nicks and commands, or one for nicks and one for commands), and then an rcirc-complete command that uses these functions to do the completion with the desired UI. I.e. basically a refactoring of rcirc-complete such that it uses the same interface between the completion data and the completion UI as the one used by completion-at-point. Then users can choose to use rcirc-complete or completion-at-point, and when/if completion-at-point (i.e. completion-in-region) gets to the point of being able to provide the same behavior as rcirc-complete, then we can get rid of rcirc-complete. Stefan