From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ryan Yeske <rcyeske@gmail.com>
Cc: 6076@debbugs.gnu.org, Leo <sdl.web@gmail.com>
Subject: bug#6076: 23.1.96; [PATCH] rcirc-complete for nicks and commands
Date: Sat, 04 Sep 2010 10:24:35 +0200 [thread overview]
Message-ID: <jwv1v993ow3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1OreVV-0002gb-67@eggplant> (Ryan Yeske's message of "Fri, 03 Sep 2010 15:13:13 -0700")
> I reviewed Leo's updated patch at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6076#47
> I agree with Leo, we should install this patch and then look into
> improvements using completion in region.
I mostly agree, but I think the patch should first be restructured into
one or 2 functions suitable for completion-at-point-functions
(i.e. either one that provides the completion data for nicks and
commands, or one for nicks and one for commands), and then an
rcirc-complete command that uses these functions to do the completion
with the desired UI.
I.e. basically a refactoring of rcirc-complete such that it uses the
same interface between the completion data and the completion UI as the
one used by completion-at-point.
Then users can choose to use rcirc-complete or completion-at-point, and
when/if completion-at-point (i.e. completion-in-region) gets to the
point of being able to provide the same behavior as rcirc-complete, then
we can get rid of rcirc-complete.
Stefan
next prev parent reply other threads:[~2010-09-04 8:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 8:49 bug#6076: 23.1.96; [PATCH] rcirc-complete for nicks and commands Leo
2010-05-02 9:01 ` Leo
2010-05-04 13:41 ` Leo
2010-05-03 16:37 ` Stefan Monnier
2010-05-03 17:45 ` Leo
2010-05-04 2:32 ` Stefan Monnier
2010-05-04 16:18 ` Juri Linkov
2010-05-04 18:29 ` Stefan Monnier
2010-05-04 20:01 ` Juri Linkov
2010-05-04 21:18 ` Stefan Monnier
2010-05-10 19:14 ` Juri Linkov
2010-05-11 1:14 ` Stefan Monnier
2010-05-11 16:54 ` Juri Linkov
2010-05-11 19:52 ` Stefan Monnier
2010-08-23 10:36 ` Leo
2010-09-03 22:13 ` Ryan Yeske
2010-09-04 8:24 ` Stefan Monnier [this message]
2010-09-04 10:21 ` Leo
2010-09-04 21:44 ` Stefan Monnier
2010-09-06 17:52 ` Leo
2010-09-11 12:55 ` Stefan Monnier
2010-09-11 13:03 ` Leo
2010-09-12 11:11 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1v993ow3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6076@debbugs.gnu.org \
--cc=rcyeske@gmail.com \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).