unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Leo Liu <sdl.web@gmail.com>
Cc: 14300@debbugs.gnu.org
Subject: bug#14300: 24.3; comint-dynamic-complete-functions breaks
Date: Sat, 04 May 2013 16:08:40 -0400	[thread overview]
Message-ID: <jwv1u9mpl3o.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m18v41alip.fsf@gmail.com> (Leo Liu's message of "Mon, 29 Apr 2013 14:39:10 +0800")

> The semantics of comint-dynamic-complete-functions has changed between
> emacs-24 and previous releases.

Indeed.

> With the new semantics it only does the first one because it will always
> (99% cases) succeed (getting the completion-table nearly always
> succeeds).

Then the code needs to be fixed not to succeed when point is somewhere
where that completion doesn't apply.

> This is unfortunate because a lot of modes rely on the previous
> behaviour to provide rich completions for comint based modes.

But that ad-hoc way to combine completions had many downsides (e.g. you
can't tell when to hide the *Completions* buffer, you can't provide
completion-help-at-point, and it interacts poorly with sophisticated
completion-styles).

> I noticed this bug because file completion no longer works in
> octave-mode.

Let's try to focus on this, then.


        Stefan





  reply	other threads:[~2013-05-04 20:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-29  6:39 bug#14300: 24.3; comint-dynamic-complete-functions breaks Leo Liu
2013-05-04 20:08 ` Stefan Monnier [this message]
2013-05-05  1:55   ` Leo Liu
2013-05-05  6:39     ` Stefan Monnier
2013-05-05  7:02       ` Leo Liu
2013-05-06  2:38         ` Stefan Monnier
2013-05-06  3:40           ` Leo Liu
2013-05-06 13:32             ` Stefan Monnier
2013-05-07  8:18               ` Leo Liu
2013-05-10  1:21                 ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1u9mpl3o.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=14300@debbugs.gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).