From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14303: 24.3; Bug in comment-search-backward Date: Fri, 17 May 2013 09:28:04 -0400 Message-ID: References: <5193B43B.8070007@easy-emacs.de> <519486DD.1040505@easy-emacs.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1368797403 26808 80.91.229.3 (17 May 2013 13:30:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 May 2013 13:30:03 +0000 (UTC) Cc: 14303@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 17 15:30:02 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UdKjQ-0003vH-Qt for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 May 2013 15:30:00 +0200 Original-Received: from localhost ([::1]:35000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdKjQ-0004CY-DQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 May 2013 09:30:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdKiF-0002Xo-ST for bug-gnu-emacs@gnu.org; Fri, 17 May 2013 09:28:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdKiE-0006cb-QD for bug-gnu-emacs@gnu.org; Fri, 17 May 2013 09:28:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdKiE-0006cX-Nc for bug-gnu-emacs@gnu.org; Fri, 17 May 2013 09:28:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UdKiU-0006SL-BQ for bug-gnu-emacs@gnu.org; Fri, 17 May 2013 09:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 May 2013 13:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14303 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14303-submit@debbugs.gnu.org id=B14303.136879733124786 (code B ref 14303); Fri, 17 May 2013 13:29:02 +0000 Original-Received: (at 14303) by debbugs.gnu.org; 17 May 2013 13:28:51 +0000 Original-Received: from localhost ([127.0.0.1]:48666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UdKhu-0006R7-IA for submit@debbugs.gnu.org; Fri, 17 May 2013 09:28:51 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:54453) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UdKhp-0006Qk-BC for 14303@debbugs.gnu.org; Fri, 17 May 2013 09:28:22 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r4HDS4J9026530; Fri, 17 May 2013 09:28:04 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 881FBB4161; Fri, 17 May 2013 09:28:04 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Fri, 17 May 2013 18:47:48 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4582=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4582> : streams <962359> : uri <1422725> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74367 Archived-At: >> Yes, same thing as with beg-of-defun discussed elsewhere. >> >> + (while (and (not found) (re-search-backward comment-start-skip limit t)) >> + (setq end (match-end 0)) >> + (or (nth 8 (syntax-ppss)) (setq found t))) >> >> This might find a comment-start inside a string. >> >> Rely at (syntax-ppss) >> >> if nt4 and nth8, goto char nth8 > There is possibility of ending up in a string. I don't understand when that can happen (when inside a string (nth 8 ppss) is also non-nil). Stefan