From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3984: Date: Tue, 17 Sep 2013 21:46:46 -0400 Message-ID: References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> <5233670E.4030703@thompsonclan.org> <5237C9FF.1000809@thompsonclan.org> <52388FEB.6020007@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1379468840 25092 80.91.229.3 (18 Sep 2013 01:47:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Sep 2013 01:47:20 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Ryan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 18 03:47:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VM6rR-0002Iz-G9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Sep 2013 03:47:21 +0200 Original-Received: from localhost ([::1]:43999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VM6rQ-0003eS-Qy for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Sep 2013 21:47:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VM6rG-0003Tx-Kw for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2013 21:47:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VM6r9-0003Eu-4G for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2013 21:47:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36923) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VM6r9-0003Eg-0O for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2013 21:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VM6r8-0008Jp-H2 for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2013 21:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Sep 2013 01:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.137946881531965 (code B ref 3984); Wed, 18 Sep 2013 01:47:02 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 18 Sep 2013 01:46:55 +0000 Original-Received: from localhost ([127.0.0.1]:45216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VM6r1-0008JU-9K for submit@debbugs.gnu.org; Tue, 17 Sep 2013 21:46:55 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:52596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VM6qy-0008JF-Pp for 3984@debbugs.gnu.org; Tue, 17 Sep 2013 21:46:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjgFABK/CFFLd/2W/2dsb2JhbABEukWESRdzgh4BAQQBViMFCws0EhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IPAS-Result: AjgFABK/CFFLd/2W/2dsb2JhbABEukWESRdzgh4BAQQBViMFCws0EhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="28229015" Original-Received: from 75-119-253-150.dsl.teksavvy.com (HELO pastel.home) ([75.119.253.150]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 17 Sep 2013 21:42:58 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 16F636324C; Tue, 17 Sep 2013 21:46:46 -0400 (EDT) In-Reply-To: <52388FEB.6020007@thompsonclan.org> (Ryan's message of "Tue, 17 Sep 2013 10:22:51 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78503 Archived-At: >>> We have "ad-is-advised" which we can use to find which stack frames >>> correspond to advised functions. We have "ad-get-orig-definition" which we >>> can use to find the original definition of an advised function. >> These are functions of advice.el, which is on the way out. We need to >> look at nadvice.el. > Wait, so defadvice and friends are going away entirely? It's very widely used, so it'll be around for a long while. It's not even marked obsolete officially yet. But it is functionally obsoleted by nadvice. > Is everything in advice.el going away, or are some parts of it going > to be converted to the new advice system? It's already been changed to work on top of nadvice.el. > Is all this documented somewhere? No, only the internals were changed, and they're usually not documented, other than in the form of actual code, and a few comments when you're lucky. > I tried the before advice, and it doesn't seem to work. With the following > code in emacs -Q: > (advice-add 'call-interactively :before #'ignore) > (defun myfun2 () > (interactive) > (or (called-interactively-p) > (error "Must be interactive!"))) > (call-interactively 'myfun2) > I get the following stack trace: Hmm, indeed, that fails already. It shouldn't be too hard to make it work, tho. Stefan