From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#3984: Date: Fri, 20 Sep 2013 15:59:47 -0400 Message-ID: References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com> <5232D333.8030206@thompsonclan.org> <523359CD.2070904@thompsonclan.org> <5233670E.4030703@thompsonclan.org> <5237C9FF.1000809@thompsonclan.org> <52388FEB.6020007@thompsonclan.org> <523A37A4.5060505@thompsonclan.org> <523A49BE.3060109@thompsonclan.org> <523AB06B.9090606@thompsonclan.org> <523B4F4E.3060204@thompsonclan.org> <523B73CF.4080105@thompsonclan.org> <523C7CDA.6040308@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1379707231 30062 80.91.229.3 (20 Sep 2013 20:00:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Sep 2013 20:00:31 +0000 (UTC) Cc: 3984@debbugs.gnu.org To: Ryan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 22:00:33 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VN6sO-0002It-CO for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2013 22:00:28 +0200 Original-Received: from localhost ([::1]:57660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN6sN-0001xU-Py for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2013 16:00:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN6sD-0001wB-Dy for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 16:00:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN6s3-0002qp-Ik for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 16:00:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN6s3-0002qA-EG for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 16:00:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VN6rz-0007Pf-7E for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2013 16:00:05 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2013 20:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 3984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 3984-submit@debbugs.gnu.org id=B3984.137970719728459 (code B ref 3984); Fri, 20 Sep 2013 20:00:03 +0000 Original-Received: (at 3984) by debbugs.gnu.org; 20 Sep 2013 19:59:57 +0000 Original-Received: from localhost ([127.0.0.1]:51843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VN6rs-0007Ov-Jd for submit@debbugs.gnu.org; Fri, 20 Sep 2013 15:59:57 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:10877) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VN6rp-0007Of-L1 for 3984@debbugs.gnu.org; Fri, 20 Sep 2013 15:59:54 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpY2x/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFFFpY2x/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="28498062" Original-Received: from 69-165-141-177.dsl.teksavvy.com (HELO pastel.home) ([69.165.141.177]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Sep 2013 15:55:49 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 2278566A4A; Fri, 20 Sep 2013 15:59:47 -0400 (EDT) In-Reply-To: <523C7CDA.6040308@thompsonclan.org> (Ryan's message of "Fri, 20 Sep 2013 09:50:34 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78628 Archived-At: > Oh, that's actually not necessary. I put it in so I could re-run the test > without restarting emacs or manually resetting the advice, and I forgot to > remove it. OK, removed. >> Since it's only used once, I don't think it's worth defining a macro for it. > Probably true. I wasn't sure how much I would end up using it, and it seemed > like a potentially useful macro to have lying around when testing advice > that might break core functions of emacs. Makes sense as well, but let's postpone putting it in until we do end up using it repeatedly. I installed some tests based on your patch, as well as my quick fix in subr.el. > That would certainly work, assuming that subr.el is always loaded before > nadvice.el (so call-interactively could not possibly be advised yet), which > seems likely to be true since subr.el contains so many core functions. Since subr.el is both preloaded and loaded very early, that should be safe, yes. > Since this bug report is just about advising call-interactively, which we > now have a fix for, should I open a separate bug about the around advice? Sure. Note also that in the tests I installed, I added one that demonstrates a problem with :filter-args as well (because :filter-args uses `funcall' rather than `apply', so it doesn't match the pattern expected by advice--called-interactively-skip). By the way, I don't see your name in our copyright assignment database. I installed your tests under "tiny change", but if you intend to contribute more, we'd need you to sign some paperwork. Would you be willing to do that? Stefan