From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Date: Fri, 04 Apr 2014 11:14:34 -0400 Message-ID: References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> <878url6whc.fsf@thinkpad-t440p.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396624593 19267 80.91.229.3 (4 Apr 2014 15:16:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Apr 2014 15:16:33 +0000 (UTC) Cc: 16090@debbugs.gnu.org, Andreas Politz To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 04 17:16:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WW5qy-0008Hf-76 for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Apr 2014 17:16:24 +0200 Original-Received: from localhost ([::1]:50654 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW5qx-0000Jv-Pk for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Apr 2014 11:16:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW5qn-0000Jc-Nr for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 11:16:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW5qd-0007EO-Ds for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 11:16:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW5qd-0007EJ-AY for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 11:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WW5qc-0003WY-G8 for bug-gnu-emacs@gnu.org; Fri, 04 Apr 2014 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Apr 2014 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16090 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16090-submit@debbugs.gnu.org id=B16090.139662450313452 (code B ref 16090); Fri, 04 Apr 2014 15:16:02 +0000 Original-Received: (at 16090) by debbugs.gnu.org; 4 Apr 2014 15:15:03 +0000 Original-Received: from localhost ([127.0.0.1]:35548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW5pe-0003Ur-Ko for submit@debbugs.gnu.org; Fri, 04 Apr 2014 11:15:03 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:37195) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW5pb-0003UC-Il for 16090@debbugs.gnu.org; Fri, 04 Apr 2014 11:15:00 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id EA02A84E0A; Fri, 4 Apr 2014 11:14:58 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 2783E1E5B74; Fri, 4 Apr 2014 11:14:35 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id E5632B4287; Fri, 4 Apr 2014 11:14:34 -0400 (EDT) In-Reply-To: <878url6whc.fsf@thinkpad-t440p.fritz.box> (Tassilo Horn's message of "Fri, 04 Apr 2014 15:43:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87747 Archived-At: >> For emacs-24, your patch is too intrusive, so I think a patch along >> the lines of Andreas's might be acceptable, but it should use >> bookmark-after-jump-hook instead of using a timer. > Like so? Almost: > (defun doc-view-bookmark-jump (bmk) > ;; This implements the `handler' function interface for record type > ;; returned by `doc-view-bookmark-make-record', which see. > (let ((page (bookmark-prop-get bmk 'page))) > (add-hook 'bookmark-after-jump-hook > (lambda () > (setq bookmark-after-jump-hook > (cdr bookmark-after-jump-hook)) Don't use `setq' on hooks. Use remove-hook. Yes I know it's more complicated, you'll have to use `make-symbol' and fset it with the above lambda. But `setq' on hooks really is much too brittle. Stefan