From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Daimrod <daimrod@gmail.com>
Cc: Ryan Yeske <rcyeske@gmail.com>, Leo Liu <sdl.web@gmail.com>,
17772@debbugs.gnu.org
Subject: bug#17772: [PATCH] Dangling channels' buffer
Date: Fri, 13 Jun 2014 14:36:16 -0400 [thread overview]
Message-ID: <jwv1tusbrjy.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87k38lay6k.fsf@tanger.home> (daimrod@gmail.com's message of "Fri, 13 Jun 2014 19:41:55 +0900")
> server process when it existed, or nil. However, since a78d87e7ed it
> raises an error.
Please avoid using Git references until we actually switch to Git.
Use dates, for example, instead.
> This is a problem if the user kills the server buffer before it kills
> the channels' buffer because it is not possible to kill them after that.
> (The function `rcirc-clean-up-buffer' is called via `kill-buffer-hook'
> and it calls `rcirc-buffer-process'.)
Your patch doesn't look bad, but I wonder if a better option wouldn't be
to try and better preserve the previous behavior. E.g. with the
patch below.
WDYT?
Stefan
=== modified file 'lisp/net/rcirc.el'
--- lisp/net/rcirc.el 2014-05-12 16:06:13 +0000
+++ lisp/net/rcirc.el 2014-06-13 18:34:01 +0000
@@ -803,9 +804,8 @@
"Return the process associated with channel BUFFER.
With no argument or nil as argument, use the current buffer."
(let ((buffer (or buffer (if (buffer-live-p rcirc-server-buffer)
- rcirc-server-buffer
- (error "Server buffer deleted")))))
- (or (with-current-buffer buffer rcirc-process)
+ rcirc-server-buffer))))
+ (or (if buffer (with-current-buffer buffer rcirc-process))
rcirc-process)))
(defun rcirc-server-name (process)
next prev parent reply other threads:[~2014-06-13 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 10:41 bug#17772: [PATCH] Dangling channels' buffer Daimrod
2014-06-13 18:36 ` Stefan Monnier [this message]
2014-06-14 1:04 ` Daimrod
2014-06-14 1:20 ` Daimrod
2014-06-30 2:59 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1tusbrjy.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17772@debbugs.gnu.org \
--cc=daimrod@gmail.com \
--cc=rcyeske@gmail.com \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).